Skip to content

Add a bracketed scalar rootfind node, kept internal for now - #5729

Draft
MarcBerliner wants to merge 12 commits into
mainfrom
claude/brent-node
Draft

Add a bracketed scalar rootfind node, kept internal for now#5729
MarcBerliner wants to merge 12 commits into
mainfrom
claude/brent-node

docs: record that the brent driver cannot cross into the solver

fa12f8d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 24, 2026 in 1s

98.08% (-0.13%) compared to 3e8d682

View this Pull Request on Codecov

98.08% (-0.13%) compared to 3e8d682

Details

Codecov Report

❌ Patch coverage is 91.37931% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.08%. Comparing base (3e8d682) to head (fa12f8d).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/pybamm/src/pybamm/expression_tree/brent.py 91.76% 14 Missing ⚠️
...ybamm/src/pybamm/discretisations/discretisation.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5729      +/-   ##
==========================================
- Coverage   98.20%   98.08%   -0.13%     
==========================================
  Files         340      341       +1     
  Lines       32743    32916     +173     
==========================================
+ Hits        32156    32285     +129     
- Misses        587      631      +44     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.