Skip to content

Ensure step and cycle lengths match - #5724

Open
NicolaCourtier wants to merge 1 commit into
pybamm-team:mainfrom
NicolaCourtier:step-cycle-numbers
Open

Ensure step and cycle lengths match#5724
NicolaCourtier wants to merge 1 commit into
pybamm-team:mainfrom
NicolaCourtier:step-cycle-numbers

Conversation

@NicolaCourtier

Copy link
Copy Markdown
Contributor

Description

A one-line fix to ensure that the step length is not longer than the cycle length.

Type of change

Add an entry under # [Unreleased] in CHANGELOG.md, in one of ## Breaking changes, ## Deprecated, ## Features, or ## Bug fixes (include PR number; breaking and deprecation entries need a one-line migration note). Internal-only PRs — refactor, docs, CI, tests — can skip this. See RELEASE.md for the full policy.

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant