Fix parser failing with irregular description syntax#1
Open
Blixibon wants to merge 1 commit intopySourceSDK:masterfrom
Open
Fix parser failing with irregular description syntax#1Blixibon wants to merge 1 commit intopySourceSDK:masterfrom
Blixibon wants to merge 1 commit intopySourceSDK:masterfrom
Conversation
Fixes parsing of I/O with no descriptions and descriptions with trailing +
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the FGD parser failing when it encounters either a trailing
+at the end of a description or an input without a description defined.For example, the following two cases occur in the default
halflife2.fgdthat cause the FGD to be cut off:fadescale(float) : "Fade Scale" : 1 : "If you specify a fade in the worldspawn, or if the engine is running under dx7, then the engine will forcibly fade out props even if fademindist/fademaxdist isn't specified." + + " This scale factor gives you some control over the fade. Using 0 here turns off the forcible fades." +I tested this and it parses the entire stock HL2 FGD with the descriptions (or lack thereof) intact, but I'm not particularly familiar with pyparsing, so let me know if this wasn't the correct way of fixing this.