Draft
Conversation
…stockfish-1 into notation-conversion
…d, give the user an option to send it themselves with a separate function, if they want to do this.
…stockfish-1 into notation-conversion
… they want. Also start testing the function a bit.
…xMatch.groups(). Also do checks for more types of invalid FENs, and write corresponding tests.
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)stockfish/models.py
|
johndoknjas
force-pushed
the
notation-conversion
branch
from
1062984 to
3bf2dd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated diff for this PR ready to be reviewed.
Note - when reviewing the diff, check that no added text has similar purpose text elsewhere. E.g., don't have two sections talking about getting the parameters in the readme, or two implementations of the same function. Also, compare the diff of the PR here to the diff of the PR from the old repo, see if all (and only all) changes present in each.
Original PR from the old repo: zhelyabuzhsky#112
This PR will probably be merged after most/all of the existing PRs from https://github.com/zhelyabuzhsky/stockfish/pull are merged in this new repo.