Repository navigation
chore(build): Purview.BuildSdk 1.3.0 and release 2.0.0-prerelease.40 - #62
Merged
Merged
Conversation
…0.0-prerelease.40
…iew.BuildSdk 1.3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Takes Purview.BuildSdk 1.3.0 and bumps this repository's own point release.
global.jsonPurview.BuildSdk1.0.0-prerelease.60->1.3.0package.jsonversion2.0.0-prerelease.39->2.0.0-prerelease.40src/src/Samples.Web/Samples.Web.csprojCA1515suppression as a deliberate exemptionsrc/src/EventSourcing/EventSourcing.csproj.agents/explicitlyWhy 1.3.0
Purview.BuildSdk1.3.0 is the current stable release on nuget.org; this repository was pinned to thepre-1.0
1.0.0-prerelease.60SDK, so this also moves the repository onto the stable 1.3.0 line. 1.3.0stops recompiling every project on every build, so every consuming repository should pick it up.
Version accounting
2.0.0-prerelease.40is the next point release after2.0.0-prerelease.39. The newest release tag inthis repository is
v2.0.0-prerelease.39, which2.0.0-prerelease.39already occupies, so the bump doesnot collide with an existing tag. The version is on a prerelease line, so the point release here is the
next prerelease increment of the same patch. No tag was pushed by hand: the release pipeline owns tagging
(
v{version}) when this merges tomain.Two source changes 1.3.0 requires
Samples.WebandPRSGD0008. 1.3.0 addsPRSGD0008(ValidatePurviewStylePolicy), so a repositorymay no longer add
CA1515(or the other accessibility rules) toNoWarnitself - the rule must be fixedrather than suppressed.
Samples.Weblegitimately suppressesCA1515: the only public type in thatassembly is the
public partial class Programthat ASP.NET Core's public-program source generator emitsfor a top-level-statements entry point. It is generated code, so it cannot be made internal here. The
project now records the same rule in
PurviewPolicyExemptNoWarn, the SDK's supported way to declare adeliberate exemption (the mechanism
aspire-resourcekit'sExample.AppHostuses forCA1034/CA1062),which keeps the rest of the accessibility policy enforced instead of opting out with
DisablePurviewStylePolicyValidation.src/src/Benchmarks/Benchmarks.csprojkeeps itsCA1515entry unchanged: the SDK injects thetest-context rule set for benchmark projects, so the entry is already exempt and the rule does not fire.
The core package and its bundled skills. 1.3.0 stopped contributing
.agents/**content to packages.It packs the
Sdk/folder verbatim, so this project's skills moved toSdk/.agents/skills/...insidePurview.EventSourcing.nupkg- a path nothing reads - which failedPackValidation:RequiredContent(.agents/**/*). The core project now packsSdk/.agents/**explicitlyat
.agents/skills/..., the pathResolvePurviewSkillSourcesreads from a restored package and the pathSdk/README.mdpromises consumers, and drops the redundant copy inside the packedSdk/folder. Thepackage keeps exactly one copy, in the same place it was before 1.3.0.
Follow-up worth considering (deliberately not done here, because it changes what consumers receive): 1.3.0
moved the repository-owned skills convention to
skills/<name>/SKILL.mdat the repository root, which iswhere every other purview-dev repository keeps them. Migrating
src/src/EventSourcing/Sdk/.agents/skillsto that location, then dropping the
.agents/**/*assertion and the README section, would align thisrepository with the SDK's new model.
Validation
dotnet restore src/EventSourcing.slnxsucceeds againstPurview.BuildSdk1.3.0.dotnet build src/EventSourcing.slnxsucceeds againstPurview.BuildSdk1.3.0: 0 errors, noPRSGD0008; the remaining warnings are the pre-existingNU1902/NU1903advisories.dotnet pack src/src/EventSourcing/EventSourcing.csprojproduces a package whose contents satisfyevery
PackValidation:RequiredContententry forpurview.eventsourcing, including.agents/skills/**/*.mdonce, at the package root.Merge
Left open for review - this PR is not merged.