Repository navigation
feat: add the persistence identifier conventions with a runnable EF Core sample - #11
Merged
Merged
Conversation
…ore sample Brings in the known-types work: three new pages (Well-Known Identifiers, GUID Key Strategy, EF Core Integration), a standalone runnable sample under samples/, and the persistence skill, template and AGENTS.md updates that go with them. The branch predates the org-harvest merge, so the conflicts are resolved in main's favour where main is newer: the purview-dev.github.io citation, the Cross-Repository Harvest link, the harvest skill row and the 'a gate is not bypassed' section all survive, and the sample is added to each. The sample is recorded as a deliberate fourth tier checked by just samples, not as a pipeline test; Verification Model says so rather than counting it as enforced. The Worked Examples test counts are corrected to the merged run (90 total, 85 succeeded, 5 skipped).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
The
known-typesbranch, merged onto currentmain(the branch predates the org-harvest work, so the merge was resolved rather than fast-forwarded).samples/Acme.Persistence: UUIDv5 derived identifiers with an idempotent, mismatch-guarded bootstrap; a sequential-GUID strategy carried as context-options data and applied by a model-finalising convention; the EF Core context, options extension, model cache key and composition.just samplesruns it and fails loudly on any untrue check. It sits outsidesrc/so the reference implementation stays in-memory.purview-persistencegains EF Core integration, well-known identifiers and provider detail plus two new references;purview-engineering-principlesnames the conditional persistence rules;templates/AGENTS.mdgains a persistence section to delete when a repository does not store data.AGENTS.md,README.md, the Home table and_Sidebar.mdall list the new pages andjust samples.Why it has benefit
The playbook already told repositories to choose a GUID strategy and to use EF Core as the boundary, but it stated neither rule and had no evidence. This makes the persistence guidance concrete, provider-correct (SQL Server and PostgreSQL order GUIDs differently) and demonstrated by code that runs.
Merge resolution
Conflicts were resolved in favour of the newer side so nothing from the harvest work is lost:
docs/wiki/Home.md: keeps the currentpurview-dev.github.iocitation and the Cross-Repository Harvest link; the branch's widened provenance sentence is kept alongside them. The stalepurview-dev/purview-devname (a redirect) is not reintroduced.docs/wiki/Verification-Model.md: keeps the A gate is not bypassed section and adds the sample as a deliberate fourth tier, checked byjust samplesand listed as Review, not as a pipeline test.AGENTS.md: keepsjust org-inventoryandjust org-inventory-write, and addsjust samples.docs/wiki/Agent-Guidance-Skills.mdandAGENTS.md: keep thepurview-org-harvestrow and take the branch's improvedpurview-persistencewording.skills/purview-persistence/SKILL.md: keepsrepository: purview-dev/engineering-playbookand takes version1.2.docs/wiki/Worked-Examples.mdquoted a stale test summary; it now shows the numbers the merged tree actually produces (90 total, 85 succeeded, 5 skipped).Verification
All run on the merged tree:
dotnet build src/EngineeringPlaybook.slnx -c Debugdotnet csharpier check .dotnet test --solution src/EngineeringPlaybook.slnx --treenode-filter=/*/*/*/*/just pipeline-prjust samplesjust samples --provider postgresqljust samples --provider uuidv7just samples --print-constantsThe 23
Repository.UnitTestscover navigation, fence languages, the organisation snapshot (including the renamed-repository check that the Home citation passes) and skill conformance.