Repository navigation
Feat/property schema justfile skills docs - #52
Merged
Merged
Conversation
…er and docs sync - Ship Sdk.props.buildschema.json (MSBuild Editor IntelliSense), the opt-in ValidatePurviewPropertySchema target (PRPSC0001-0004) and PropertySchemaTests holding the code, compiler-visible list and docs tables to it. - Add TargetFrameworkOwnership.targets so an explicit TargetFramework(s) always wins over the curated sets. - Add the purview-buildsdk-justfile skill and its .build/just modules (barrel, env, version/bump, dotnet, utilities, pipeline, skills, optional nuget/docs); the root Justfile imports only the barrel. JustModuleParityTests keeps them in step. Fold purview-buildsdk-skills-justfile into it. - Add the purview-buildsdk-docs-sync and purview-buildsdk-msbuild-properties skills. - Make the skill targets a thin wrapper over the standard skills CLI: InstallPurviewSkills adds PurviewSkillsSource or restores skills-lock.json; remove the package-to-skill mapping, List/Recommend/VerifyPurviewSkills and PRSKL0001/0002/0010-0014/0017. - Fix a relative RootPackageJson resolving against the working directory, and IncludeLinkedSdkFiles stripping Sdk/ from every linked file. - Count only property-pass reads as pre-import in PropertySchemaTests, and drop the false pre-import claims from eight schema descriptions. - Restructure docs/wiki into topic folders with DocumentationWikiTests, and audit README, wiki, skills and AGENTS.md against the code. - Declare the new Sdk files in .config/purview-build.json RequiredContent.
…off -mt TreatWarningsAsErrors now defaults to true for every project, not only Roslyn components. Compiler, analyzer and NuGet warnings fail the build; set TreatWarningsAsErrors=false to opt out. A net11.0 Blazor WebAssembly client cannot build under MSBuild -mt: the WebAssembly SDK's ReadWasmProps task fails with MSB4060. A client now writes -mt:false to the managed Directory.Build.rsp, naming itself, and other projects keep that while the client exists. An explicit PurviewMultiThreadedBuild always wins and a user-owned file is never rewritten. A client built under -mt anyway stops with PRBLZ0002 before PrepareForBuild, saying where -mt came from and how to turn it off. BREAKING CHANGE: repositories that build with warnings fail until they fix them or set TreatWarningsAsErrors=false.
Every project reads and may rewrite the one response file. Reading it with File.ReadAllText in a property function failed with MSB4184 while another project replaced it, and a library that read the file before the WebAssembly client rewrote it could write -mt back afterwards, so the next build stopped with PRBLZ0002. The read now runs in its own target through a task that shares the file with writers and retries; a file that stays unreadable is left alone. SyncPurviewRepositoryFiles takes a lock per destination before writing and looks again: a file that appeared since is kept, and with KeepWhenNamedFileExists a project without its own setting keeps a file naming a WebAssembly client that exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.