Repository navigation
fix: make Runtime Async opt-in and release 2.0.1 - #50
Merged
Merged
Conversation
Runtime Async changes how every await compiles, so enabling it for every net11.0+ target was too broad a default. It is now off unless opted in with PurviewRuntimeAsync=true or UseRuntimeAsync=true; an explicit false under either name keeps it off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runtime Async is now off by default for
net11.0+ targets.It changes how every
awaitcompiles, so enabling it for every target was too broad a default. It isnow opted into explicitly:
PurviewRuntimeAsync=true, orUseRuntimeAsync=true(the name the .NET team uses).An explicit
falseunder either name keeps it off, regardless of how it was enabled.Changes
Targets/Modern.targetsresolves the switch at target-evaluation time (after the project body), soboth names work from the project file as well as
Directory.Build.props.Props/Defaults.propsno longer forces the property on at import time.Validation
dotnet test --project src/BuildSdk.slnx --configuration Release— 1448 passed, 0 failedjust lint-checkjust skills-validatejust version-sync-check