Skip to content

test: match inlined svg icons regardless of whitespace and quotes #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kieronlanning merged 1 commit into from
Nov 13, 2026
Merged

test: match inlined svg icons regardless of whitespace and quotes #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions scripts/smoke.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,16 @@ if (packIconCount === 0) {
const leaked = [...imageIconSrcs].filter((src) => src.startsWith('file://'));
if (leaked.length > 0) failures.push(`Icons: build-machine path reached an <img src> — ${leaked[0]}`);

/** LikeC4 inlines some local SVGs as `data:` URIs, so either form counts. */
/**
* LikeC4 inlines some local SVGs as `data:` URIs, so either form counts. The
* encoder collapses whitespace and swaps quotes, so compare with both stripped.
*/
function rendered(url: string, file: URL): boolean {
const svg = readFileSync(file, 'utf8').trim();
const normalise = (svg: string) => svg.replace(/\s+|["']/g, '');
const svg = normalise(readFileSync(file, 'utf8')).slice(0, 120);

return [...imageIconSrcs].some(
(src) => src === url || (src.startsWith('data:image/svg+xml') && decodeURIComponent(src).includes(svg.slice(0, 60).replaceAll('"', "'"))),
(src) => src === url || (src.startsWith('data:image/svg+xml') && normalise(decodeURIComponent(src)).includes(svg)),
);
}

Expand Down
Loading