Make keytool path configureable - #477
Merged
Merged
Conversation
rwaffen
approved these changes
Aug 31, 2026
Member
|
Test PR created to run CI against this change: #478 |
Member
|
Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-java_ks/actions/runs/33513994412?pr=478 SLES 12 is still running, but it's doing the typical provisioning issue which causes SLES 12 to always fail to run tests, which matches against main/nightly results. Otherwise, all acceptance tests are passing. This seems like a small and targeted configuration change, no issues seen here. Needs engineering team review when they are available. |
Usecase: I need to manipulate the PE keystore. The provided `keytool` binary lives at /opt/puppetlabs/server/bin/keytool. This patch makes it configureable. The default is still the relative `keytool`, which will be used in $PATH. This makes it an enhancement, not a breaking change.
Member
|
@imaqsood : The PR was out of date with main so I've rebased it. Needs a quick re-review to make sure everything is still good. |
imaqsood
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usecase: I need to manipulate the PE keystore. The provided
keytoolbinary lives at /opt/puppetlabs/server/bin/keytool. This patch makes it configureable. The default is still the relativekeytool, which will be used in $PATH. This makes it an enhancement, not a breaking change.Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)