fix(AccountList): auto-select first enabled account after load (#245)#248
Merged
fix(AccountList): auto-select first enabled account after load (#245)#248
Conversation
… WPF defaults SelectedIndex to 0 on redrawSAccountList. The SPA left selectedSid as null after load, requiring a manual click before Get OTP / Start Game would work. Now auto-selects the first enabled account after getServiceAccounts completes, matching WPF behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
After login, the account list loaded but no row was selected — users had to manually click a row before Get OTP or Start Game would work. WPF defaults
SelectedIndexto 0 onredrawSAccountList, auto-selecting the first account.Fix
After
getServiceAccountscompletes and the drag-order is applied, auto-select the first enabled (non-banned) account if nothing is already selected.Tests
Updated 3 test files — assertions that expected
selectedSid === nullafter mount now expect'sid-1'(the first enabled account). The "no selection" guard tests explicitly clearselectedSidbefore asserting.Closes #245