fix(deps): align the wasm-tools crate family to the 252 release (#465)#466
Merged
Conversation
cpetig (#465): the wasm-tools-family deps in the workspace Cargo.toml were pinned at MIXED upstream releases — dependabot bumped wasmparser→0.252 and (lock) wat, but left wasm-encoder 0.248, wit-parser 0.244, wit-component 0.244 behind, duplicating their shared internal deps in the tree. Align all to release 252: wasm-encoder 0.248 → 0.252 wit-parser 0.244 → 0.252 wit-component 0.244 → 0.252 wat 1.219 → 1.252 (wasmparser 0.252 and wast 252.0 were already current.) Collapses the 0.247 + 0.248 duplicate copies into 0.252. These are synth-frontend-only (Component Model parsing) + the wat/wast test parsers; the ARM/RISC-V codegen path is untouched. FROZEN-SAFE: no codegen change. Frozen byte gates bit-identical (control_step 0x00210A55 / flight_seam / flight_seam_flat / signed_div — wat 1.252 parses the fixtures to the same bytes); full frontend/core/cli/test suites green. No version bump (dep-only) — rides the next release. RESIDUAL (out of scope, noted for #465): a 0.244 wasm-tools copy remains, pulled NOT by our manifest but transitively by wit-bindgen's own pinned wit-component 0.244, deep via the z3-sys build chain (wasip2→getrandom→…→z3-sys→synth-verify). Resolvable only when wit-bindgen updates upstream. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #465.
What
@cpetig flagged that the wasm-tools-family deps in the workspace
Cargo.tomlwere pinned at mixed upstream releases, duplicating their shared internal deps. Dependabot had bumpedwasmparser→0.252 (and the lock'swat) but left the rest behind. Aligns all to release 252:Collapses the 0.247 + 0.248 duplicate copies into 0.252. These are
synth-frontend-only (Component Model parsing) plus thewat/wasttest parsers — the ARM/RISC-V codegen path is untouched.Frozen-safe
No codegen change. Frozen byte gates bit-identical (control_step
0x00210A55/ flight_seam / flight_seam_flat / signed_div —wat1.252 parses the fixtures to the same bytes); full frontend/core/cli/test suites green. No version bump (dep-only) — rides the next release.Residual (out of scope, noted)
One 0.244 wasm-tools copy remains — pulled not by our manifest but transitively by
wit-bindgen's own pinnedwit-component 0.244, deep via the z3-sys build chain (wasip2 → getrandom → … → z3-sys → synth-verify). That only resolves whenwit-bindgenupdates upstream.🤖 Generated with Claude Code