test(resource): #305 — opaque-rep construct+drop runtime oracle (resolved, no meld fix)#309
Merged
Conversation
…lved, no meld fix) Built the repro (resource_floats_opaque composed component from the wit-bindgen fork feat/opaque-rep-attribute 51eca6b6, with the user-supplied opaque-rep dtor) and ran it through meld. Result: meld fuses the 3-component re-exporter chain (--output component, 163 KB, 695 funcs, 4 adapters) AND construct+drop runs cleanly on wasmtime. The original drop-teardown trap was the wit-bindgen-side opaque-rep destructor (missing inner-handle forwarding); the fork's dtor fixes it. meld needed no handle-table change — the suspected merger.rs/fact.rs fix was not required (verified by running the repro, not editing Tier-5 code blind). Lands the regression oracle test_runtime_wit_bindgen_resource_floats_opaque. Fixture gitignored (~11 MB; regenerate per tests/wit_bindgen/README.md — recipe added); test skips in CI when absent (load-bearing local oracle). SR-43 proposed -> verified. Closes #305. Also syncs Cargo.lock to 0.34.0 (the v0.34 release bumped Cargo.toml but not the lockfile). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
LS-N verification gate✅ 57/57 approved LS entries verified
Approved Failed LS entries(none) Missing regression tests(none) Updated automatically by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drove #305 to ground by building the repro and running it, rather than editing Tier-5 resource code blind.
Outcome: #305 is resolved; meld needs no change
resource_floats_opaque.wasmfrom the wit-bindgen forkfeat/opaque-rep-attribute(51eca6b6— "user-supplied dtor for opaque-rep export resources").--output component, 163 KB, 695 funcs, 4 adapters) andconstruct+dropruns cleanly on wasmtime.merger.rs/fact.rs) was not required — verified empirically by running the repro.What this lands
test_runtime_wit_bindgen_resource_floats_opaque— fuses + construct+drop regression oracle. Fixture is gitignored (~11 MB; recipe added totests/wit_bindgen/README.md), so it skips in CI when absent and is the load-bearing local oracle (same posture as other large fixtures).proposed → verified.Cargo.locksynced to 0.34.0 (v0.34 release bumpedCargo.tomlonly).No meld code change ⇒ this is verification closure, not a versioned release. Closes #305.