chore(testsuite): re-pin to latest (193e551) + monthly re-pin workflow (kiln#360)#361
Merged
Conversation
…thly re-pin workflow Resolves the kiln#360 confound: the submodule was unpinned (gitlink c337f0d ≠ checked-out 7e0b83a), so fresh worktrees/CI silently tested a different suite — which looked like runner non-determinism but was a submodule-version mismatch. Same-commit runs are deterministic. - Pins the gitlink to WebAssembly/testsuite @193e551 (latest, 2026-06-17), matching the checkout, so conformance is reproducible across CI/worktrees. - Adds .github/workflows/testsuite-repin.yml: monthly (+ manual) job that bumps to latest upstream, re-measures WAST conformance, and opens a PR for review of the new baseline (spec evolution can add failing files → reviewed, not auto-merged). - Updates the conformance note: 263/281 files pass, 65980 assertions pass / 529 fail @193e551 (vs the stale '332/74 @7e0b83a'). Bumping 7e0b83a→193e551 added +184 passing assertions and +1 passing file with ZERO new failures. rivet validate: 0 errors.
🔍 Build Diagnostics ReportSummary
🎯 Impact AnalysisIssues in Files You Modified
Cascading Issues (Your Changes Breaking Other Files)
✅ No Issues DetectedPerfect! Your changes don't introduce any new errors or warnings, and don't break any existing code. 📊 Full diagnostic data available in workflow artifacts 🔧 To reproduce locally: # Install cargo-kiln
cargo install --path cargo-kiln
# Analyze your changes
cargo-kiln build --output json --filter-severity error
cargo-kiln check --output json --filter-severity warning |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the kiln#360 confound and establishes the "regularly re-pin" practice.
The confound (kiln#360)
external/testsuitewas unpinned: gitlink recordedc337f0dwhile the working tree had7e0b83achecked out. So a freshgit worktree/CI checkout tested a different suite than the main worktree — which looked like ±18-assertion runner non-determinism but was a submodule-version mismatch. Same-commit runs are deterministic (verified: thecastcluster and full-suite non-type-subtyping results are identical across runs).What this does
WebAssembly/testsuite @193e551(latest, 2026-06-17), matching the checkout → conformance is now reproducible across CI/worktrees..github/workflows/testsuite-repin.yml— monthly (+workflow_dispatch) job that bumps to latest upstream, re-runs WAST conformance, and opens a PR for review of the new baseline (spec evolution can add failing files, so it's reviewed, not auto-merged). This is the "regularly re-pin" cadence while keeping it pinned at all times.architecture-components.yamlwith the real, reproducible baseline.New baseline (measured from source @193e551)
263/281 files pass; 65980 assertions pass / 529 fail. Bumping
7e0b83a → 193e551added +184 passing assertions and +1 passing file with zero new failures — the spec evolution is strictly more coverage that kiln handles. Remaining 17 failing files dominated by the GC custom-descriptors proposal +br_on_cast/return_call_ref(Issue 149).Note
PRs opened by the scheduled job use the default
GITHUB_TOKEN, which doesn't re-trigger CI on the auto-PR — a human reviewer re-runs CI when reviewing the new baseline (acceptable, since the baseline needs human review anyway).rivet validate: 0 errors. Refs kiln#360, #149.
🤖 Generated with Claude Code