chore(rivet): close the V's right side + migrate to rivet 0.17 (canonical statuses + aspice)#357
Merged
Merged
Conversation
…ies markers + status (#340) Maps the 6 shipped witness-backend tests to REQ_WITNESS_COV via `// rivet: verifies` source markers (rivet coverage --tests), and advances REQ_WITNESS_COV proposed -> implemented to reflect v0.3.4 shipping Phases 1+2. This is the first right-side-of-V closure in the project (per pulseengine.eu#88): - kiln-runtime/tests/witness_snapshot_test.rs (2 markers) - kilnd/src/witness_harness.rs (4 markers) Verified: `rivet coverage --tests` maps all 6 markers to REQ_WITNESS_COV; witness tests still pass (marker is a comment). Verifies: REQ_WITNESS_COV
…t aspice schema
rivet 0.17.0 locked the status enum (REQ-162) to draft/proposed/approved/
implemented/verified/released/accepted/deprecated/rejected, turning kiln's
off-vocabulary statuses into 57 validate errors. Migrated to canonical values
(bulk `rivet modify --where`):
- planned -> proposed (27) planned-for-release = proposed
- partial -> implemented (21) partial work exists; verification now tracked
via `// rivet: verifies` markers
- delegated -> proposed (8) owned/pending elsewhere
- removed -> deprecated (1)
Also adds the `aspice` schema (V-model verification types: unit-verification,
verification-execution, …) so the right side of the V is representable.
rivet validate: 0 errors (was 0 on 0.15.0; 57 on 0.17.0 pre-migration).
Witness `verifies` markers still map (coverage --tests). See pulseengine.eu#88,
rivet#559.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
🔍 Build Diagnostics ReportSummary
🎯 Impact AnalysisIssues in Files You Modified
Cascading Issues (Your Changes Breaking Other Files)
✅ No Issues DetectedPerfect! Your changes don't introduce any new errors or warnings, and don't break any existing code. 📊 Full diagnostic data available in workflow artifacts 🔧 To reproduce locally: # Install cargo-kiln
cargo install --path cargo-kiln
# Analyze your changes
cargo-kiln build --output json --filter-severity error
cargo-kiln check --output json --filter-severity warning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome of a release-readiness check that surfaced the verification-mapping gap (pulseengine.eu#88) and a rivet-upgrade migration.
What this does
// rivet: verifies REQ_WITNESS_COVmarkers to all 6 witness tests (kiln-runtime ×2, kilnd ×4);rivet coverage --testsmaps them. AdvancesREQ_WITNESS_COVproposed→implemented (v0.3.4 shipped Phases 1+2). First right-side-of-V closure in the project.rivet modify --where:planned→proposed(27),partial→implemented(21),delegated→proposed(8),removed→deprecated(1).aspiceschema — V-model verification types (unit-verification,verification-execution, …) so verification is representable.Verification
rivet validate: 0 errors on rivet 0.17.0 (was 0 on 0.15.0; 57 on 0.17.0 pre-migration)rivet coverage --tests: all 6 witness markers map toREQ_WITNESS_COVFriction filed (dogfooding)
coverage --tests) but isn't wired intorivet coverageor the release gate, soverifiedstatus is unreachable; (b)import-resultsdoesn't link to requirements; (c) 0.17 upgrade breaks a clean gate via the status-enum tightening (no migration path surfaced); (d)unknown-fielddoc says INFO but behaves as… (status enum) ERROR.Not solved here
A passing
verifiesmarker still doesn't advance a requirement toverifiedor count inrivet coverage(rivet#559 item 2). So the release gate's right side is now mapped but not yet gating — that's a rivet fix, tracked.🤖 Generated with Claude Code