Skip to content

test: write package.json for dependency install canary test#15

Open
pullfrog[bot] wants to merge 21 commits into
mainfrom
pullfrog/test-dep-install
Open

test: write package.json for dependency install canary test#15
pullfrog[bot] wants to merge 21 commits into
mainfrom
pullfrog/test-dep-install

Conversation

@pullfrog
Copy link
Copy Markdown

@pullfrog pullfrog Bot commented Apr 12, 2026

This PR captures the package.json change made during a dependency installation behavior test. The file was overwritten as part of the test task to verify postinstall script execution via start_dependency_installation / await_dependency_installation.

Pullfrog  | Triggered by Pullfrog | Using Claude Opus𝕏


Note

Medium Risk
Adds a postinstall script that writes to /tmp, which will execute automatically during dependency installs and can affect CI/host environments. Otherwise changes are small and isolated to npm metadata files.

Overview
Updates package.json to rename the package to test-pkg, add a version, and replace the test script with a postinstall canary that writes CANARY_MARKER to /tmp/postinstall-canary.txt.

Adds a minimal package-lock.json to accompany the updated npm package metadata.

Reviewed by Cursor Bugbot for commit e14ecf2. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread package.json
}
"postinstall": "echo CANARY_MARKER > /tmp/postinstall-canary.txt"
},
"dependencies": {}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test package.json overwrites real project configuration

High Severity

The root package.json appears to have been overwritten with a canary-test-only version. This removes "private": true (risking accidental npm publish), "type": "module" (breaking existing ES module imports in src/ and test/), and the "test": "vitest run" script (breaking npm test). The existing test/math.test.ts imports from vitest and uses ES module syntax, which will no longer work. Per the PR description, this file was "overwritten as part of the test task" — it looks like a test artifact that was accidentally committed.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ab76b76. Configure here.

Comment thread package-lock.json
"requires": true,
"packages": {
"": {
"name": "test-repo"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package name mismatch between lockfile and manifest

Medium Severity

The package-lock.json uses "name": "test-repo" (in both the root and the packages[""] entry) while package.json was changed to "name": "test-pkg". This mismatch means npm will detect an inconsistency and may regenerate the lockfile on install, which could interfere with the deterministic behavior expected by the canary test.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 17fb087. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 767a1ad. Configure here.

Comment thread package.json
"name": "test-repo",
"private": true,
"type": "module",
"name": "test-pkg",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name mismatch between package.json and package-lock.json

Medium Severity

The package.json declares "name": "test-pkg" while the new package-lock.json declares "name": "test-repo". This mismatch causes npm to emit warnings and may lead to unexpected behavior during dependency installation—the very operation this canary test is meant to verify.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 767a1ad. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants