Repository navigation
Fix reported defects in time-based UUIDs, MD5 digests, and C++ version linkage. - #260
Merged
Merged
Conversation
KGronek-Pubnub
marked this pull request as ready for review
October 21, 2026 07:14
KGronek-Pubnub
requested review from
Xavrax,
kazydek,
parfeon and
techwritermat
as code owners
October 21, 2026 07:14
Contributor
Author
|
@pubnub-release-bot release |
Contributor
|
🚀 Release successfully completed 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(uuid): Copy the caller node into time-based UUIDs
pubnub_generate_uuid_v1_timecopied from the address of thei_nodeparameter instead of the six node bytes the caller passed. The node field of a version 1 UUID now matches that input.fix(md5): Finalize digests with the updated context
pbmd5_digestandpbmd5_digest_strpassedM_ctxtoMD5_Finalwhile the bytes were hashed inM_ctx_. Those macros now finalize the context they initialized and updated, in bothlib/md5/pbmd5.handopenssl/pbmd5.h.fix(cpp): Use C linkage for version functions when requested
When
PUBNUB_USE_EXTERN_Cis set,pubnub_version.hand the POSIX and Windows C++ version sources declare and definepubnub_uname,pubnub_uagent, and the other version functions with C linkage. C++ callers, including core sources built as C++, resolve the same symbols as C.Closes #106 #242 #225