Skip to content

Fix reported defects in time-based UUIDs, MD5 digests, and C++ version linkage. - #260

Merged
KGronek-Pubnub merged 4 commits into
masterfrom
fix/reported_issues
Oct 26, 2026
Merged

KGronek-Pubnub merged 4 commits into
masterfrom
fix/reported_issues

Conversation

@KGronek-Pubnub

@KGronek-Pubnub KGronek-Pubnub commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

fix(uuid): Copy the caller node into time-based UUIDs

pubnub_generate_uuid_v1_time copied from the address of the i_node parameter instead of the six node bytes the caller passed. The node field of a version 1 UUID now matches that input.

fix(md5): Finalize digests with the updated context

pbmd5_digest and pbmd5_digest_str passed M_ctx to MD5_Final while the bytes were hashed in M_ctx_. Those macros now finalize the context they initialized and updated, in both lib/md5/pbmd5.h and openssl/pbmd5.h.

fix(cpp): Use C linkage for version functions when requested

When PUBNUB_USE_EXTERN_C is set, pubnub_version.h and the POSIX and Windows C++ version sources declare and define pubnub_uname, pubnub_uagent, and the other version functions with C linkage. C++ callers, including core sources built as C++, resolve the same symbols as C.

Closes #106 #242 #225

@KGronek-Pubnub KGronek-Pubnub self-assigned this Oct 20, 2026
@KGronek-Pubnub
KGronek-Pubnub marked this pull request as ready for review October 21, 2026 07:14

@parfeon parfeon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KGronek-Pubnub

Copy link
Copy Markdown
Contributor Author

@pubnub-release-bot release

@KGronek-Pubnub
KGronek-Pubnub merged commit aa23bf1 into master Oct 26, 2026
8 checks passed
@KGronek-Pubnub
KGronek-Pubnub deleted the fix/reported_issues branch October 26, 2026 13:25
@pubnub-release-bot

Copy link
Copy Markdown
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants