Skip to content

fix: fall back to search page when homepage lacks ondemand.s #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnuhpc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fall back to search page when homepage lacks ondemand.s #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion twitter_cli/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1109,7 +1109,23 @@ def _ensure_client_transaction(self):
home_page_response = bs4.BeautifulSoup(home_page.content, "html.parser")
ondemand_url = get_ondemand_file_url(response=home_page_response)
if not ondemand_url:
raise ValueError("Failed to extract ondemand file URL from homepage")
# X redesigned its homepage; the search page still has the
# legacy frontend with ondemand.s. Fall back to it.
search_page = cffi_session.get(
"https://x.com/search?q=AI&f=live",
headers=ct_headers, timeout=10,
)
search_response = bs4.BeautifulSoup(
search_page.content, "html.parser"
)
ondemand_url = get_ondemand_file_url(response=search_response)
if not ondemand_url:
raise ValueError(
"Failed to extract ondemand file URL from homepage "
"and search page"
)
home_page_response = search_response
home_page = search_page
ondemand_file = cffi_session.get(
ondemand_url, headers=ct_headers, timeout=10,
)
Expand Down