Skip to content

Forget a stored peer path whose length byte is invalid (iteration branch) #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptr727 wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Forget a stored peer path whose length byte is invalid (iteration branch) #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d85ab5
Forget a stored peer path whose length byte is invalid
ptr727 Oct 10, 2026
89f732f
Apply the stored path check in the secure-chat loader too
ptr727 Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions examples/companion_radio/DataStore.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,10 @@ File file = openRead(_getContactsChannelsFS(), "/contacts3");

if (!success) break; // EOF

if (c.out_path_len != OUT_PATH_UNKNOWN && !mesh::Packet::isValidPathLen(c.out_path_len)) {
c.out_path_len = OUT_PATH_UNKNOWN; // corrupt entry: rediscover the path rather than send DIRECT on a bad one
}

c.id = mesh::Identity(pub_key);
if (!host->onContactLoaded(c)) full = true;
}
Expand Down
4 changes: 4 additions & 0 deletions examples/simple_secure_chat/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,10 @@ class MyMesh : public BaseChatMesh, ContactVisitor {

if (!success) break; // EOF

if (c.out_path_len != OUT_PATH_UNKNOWN && !mesh::Packet::isValidPathLen(c.out_path_len)) {
c.out_path_len = OUT_PATH_UNKNOWN; // corrupt entry: rediscover the path rather than send DIRECT on a bad one
}

c.id = mesh::Identity(pub_key);
c.lastmod = 0;
if (!addContact(c)) full = true;
Expand Down
4 changes: 4 additions & 0 deletions src/helpers/ClientACL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ void ClientACL::load(FILESYSTEM* fs, const mesh::LocalIdentity& self_id) {

if (!success) break; // EOF

if (c.out_path_len != OUT_PATH_UNKNOWN && !mesh::Packet::isValidPathLen(c.out_path_len)) {
c.out_path_len = OUT_PATH_UNKNOWN; // corrupt entry: rediscover the path rather than send DIRECT on a bad one
Comment thread
ptr727 marked this conversation as resolved.
}

c.id = mesh::Identity(pub_key);
self_id.calcSharedSecret(c.shared_secret, pub_key); // recalculate shared secrets in case our private key changed
if (num_clients < MAX_CLIENTS) {
Expand Down
Loading