Repository navigation
Refer to an Enumeration Instead of Stating an Incidental Count - #3168
Merged
Merged
Conversation
Add an "Incidental Counts" rule to GOVERNANCE.md "Documentation Style Conventions", carried whole into comment-and-doc-style as a generated include, and point fleet-code-review at it. Remove the incidental counts the carried text already held. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rebind pronouns that pointed at the wrong noun once a count was gone, finish the half-removed counts later in the same paragraphs, keep the ordinal-structured count in backlog-burndown, apply the rule to the References carve-outs, and drop "a version" from the rule's list of counts the reader needs, since a version is not an enumeration size. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ptr727
added
documentation
Owner
Author
|
A recorded local strict-review pass covers head |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Remaining incidental counts, a grammar error, and incomplete fleet-wide cleanup must be addressed.
No open issues 🎉
What changed in this PR
This documentation-focused PR introduces a fleet-wide rule against incidental enumeration counts and updates canonical and generated skill content.
Changes:
- Adds the
Incidental Countsgovernance rule. - Removes stale incidental counts across documentation, scripts, and skills.
- Regenerates skill distributions and source digests.
| File | Reviewed change |
|---|---|
WORKFLOW.md |
Updates workflow enumeration wording. |
scripts/README.md |
Updates handoff documentation. |
scripts/handoff.py |
Updates the module docstring. |
GOVERNANCE.md |
Adds the canonical rule. |
CODESTYLE.md |
Removes incidental count wording. |
AGENTS.md |
Updates agent guidance. |
.github/skills/workflow-ci-contract/SKILL.md |
Updates generated workflow guidance. |
.github/skills/workflow-ci-contract/references/test-methodology.md |
Updates generated methodology guidance. |
.github/skills/unattended-handoff/SKILL.md |
Updates generated handoff guidance. |
.github/skills/session-handoff/SKILL.md |
Updates generated session guidance. |
.github/skills/repo-worktree/SKILL.md |
Updates generated worktree guidance. |
.github/skills/python-codestyle/references/code-style.md |
Updates generated Python guidance. |
.github/skills/merge-and-release/SKILL.md |
Updates generated release guidance. |
.github/skills/local-strict-review/SKILL.md |
Updates generated review guidance. |
.github/skills/git-commit-conventions/references/history-rewrite.md |
Updates generated Git guidance. |
.github/skills/fleet-code-review/SKILL.md |
Adds generated count-review guidance. |
.github/skills/dotnet-codestyle/SKILL.md |
Updates generated .NET guidance. |
.github/skills/comment-and-doc-style/SKILL.md |
Carries the generated rule. |
.github/skills/comment-and-doc-style/references/carried-doc-references.md |
Updates generated reference guidance. |
.github/skills/carried-instruction-file-guard/SKILL.md |
Updates generated guard guidance. |
.github/skills/branching-and-release-model/references/release-publish-mechanics.md |
Updates generated release guidance. |
.github/skills/branching-and-release-model/references/branch-protection-and-promotion.md |
Updates generated promotion guidance. |
.github/skills/backlog-burndown/SKILL.md |
Updates generated backlog guidance. |
.github/skills/audit-a-repo/SKILL.md |
Updates generated audit guidance. |
.github/skills/agent-conduct/SKILL.md |
Updates generated conduct guidance. |
.claude-plugin/fleet-skills/skills/workflow-ci-contract/SKILL.md |
Updates generated plugin workflow guidance. |
.claude-plugin/fleet-skills/skills/workflow-ci-contract/references/test-methodology.md |
Updates generated plugin methodology guidance. |
.claude-plugin/fleet-skills/skills/unattended-handoff/SKILL.md |
Updates generated plugin handoff guidance. |
.claude-plugin/fleet-skills/skills/session-handoff/SKILL.md |
Updates generated plugin session guidance. |
.claude-plugin/fleet-skills/skills/repo-worktree/SKILL.md |
Updates generated plugin worktree guidance. |
.claude-plugin/fleet-skills/skills/python-codestyle/references/code-style.md |
Updates generated plugin Python guidance. |
.claude-plugin/fleet-skills/skills/merge-and-release/SKILL.md |
Updates generated plugin release guidance. |
.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md |
Updates generated plugin review guidance. |
.claude-plugin/fleet-skills/skills/git-commit-conventions/references/history-rewrite.md |
Updates generated plugin Git guidance. |
.claude-plugin/fleet-skills/skills/fleet-code-review/SKILL.md |
Adds generated plugin count-review guidance. |
.claude-plugin/fleet-skills/skills/dotnet-codestyle/SKILL.md |
Updates generated plugin .NET guidance. |
.claude-plugin/fleet-skills/skills/comment-and-doc-style/SKILL.md |
Carries the generated plugin rule. |
.claude-plugin/fleet-skills/skills/comment-and-doc-style/references/carried-doc-references.md |
Updates generated plugin references. |
.claude-plugin/fleet-skills/skills/carried-instruction-file-guard/SKILL.md |
Updates generated plugin guard guidance. |
.claude-plugin/fleet-skills/skills/branching-and-release-model/references/release-publish-mechanics.md |
Updates generated plugin release guidance. |
.claude-plugin/fleet-skills/skills/branching-and-release-model/references/branch-protection-and-promotion.md |
Updates generated plugin promotion guidance. |
.claude-plugin/fleet-skills/skills/backlog-burndown/SKILL.md |
Updates generated plugin backlog guidance. |
.claude-plugin/fleet-skills/skills/audit-a-repo/SKILL.md |
Updates generated plugin audit guidance. |
.claude-plugin/fleet-skills/skills/agent-conduct/SKILL.md |
Updates generated plugin conduct guidance. |
.claude-plugin/fleet-skills/.source-digests/workflow-ci-contract |
Updates the source digest. |
.claude-plugin/fleet-skills/.source-digests/unattended-handoff |
Updates the source digest. |
.claude-plugin/fleet-skills/.source-digests/session-handoff |
Updates the source digest. |
.claude-plugin/fleet-skills/.source-digests/repo-worktree |
Updates the source digest. |
.claude-plugin/fleet-skills/.source-digests/python-codestyle |
Updates the source digest. |
.claude-plugin/fleet-skills/.source-digests/merge-and-release |
Updates the source digest. |
.claude-plugin/fleet-skills/.source-digests/local-strict-review |
Updates the source digest. |
.claude-plugin/fleet-skills/.source-digests/git-commit-conventions |
Updates the source digest. |
.claude-plugin/fleet-skills/.source-digests/fleet-code-review |
Updates the source digest. |
.claude-plugin/fleet-skills/.source-digests/dotnet-codestyle |
Updates the source digest. |
.claude-plugin/fleet-skills/.source-digests/comment-and-doc-style |
Updates the source digest. |
.claude-plugin/fleet-skills/.source-digests/carried-instruction-file-guard |
Updates the source digest. |
.claude-plugin/fleet-skills/.source-digests/branching-and-release-model |
Updates the source digest. |
.claude-plugin/fleet-skills/.source-digests/backlog-burndown |
Updates the source digest. |
.claude-plugin/fleet-skills/.source-digests/audit-a-repo |
Updates the source digest. |
.claude-plugin/fleet-skills/.source-digests/agent-conduct |
Updates the source digest. |
.agents/skills/workflow-ci-contract/SKILL.md |
Updates workflow guidance. |
.agents/skills/workflow-ci-contract/references/test-methodology.md |
Updates methodology guidance. |
.agents/skills/unattended-handoff/SKILL.md |
Updates handoff guidance. |
.agents/skills/session-handoff/SKILL.md |
Updates session guidance. |
.agents/skills/repo-worktree/SKILL.md |
Updates worktree guidance. |
.agents/skills/python-codestyle/references/code-style.md |
Updates Python guidance. |
.agents/skills/merge-and-release/SKILL.md |
Updates release guidance. |
.agents/skills/local-strict-review/SKILL.md |
Updates review guidance. |
.agents/skills/git-commit-conventions/references/history-rewrite.md |
Updates Git guidance. |
.agents/skills/fleet-code-review/SKILL.md |
Adds count-review guidance. |
.agents/skills/dotnet-codestyle/SKILL.md |
Updates .NET guidance. |
.agents/skills/comment-and-doc-style/SKILL.md |
Carries the new rule. |
.agents/skills/comment-and-doc-style/references/carried-doc-references.md |
Updates reference guidance. |
.agents/skills/carried-instruction-file-guard/SKILL.md |
Updates guard guidance. |
.agents/skills/branching-and-release-model/references/release-publish-mechanics.md |
Updates release guidance. |
.agents/skills/branching-and-release-model/references/branch-protection-and-promotion.md |
Updates promotion guidance. |
.agents/skills/backlog-burndown/SKILL.md |
Updates backlog guidance. |
.agents/skills/audit-a-repo/SKILL.md |
Updates audit guidance. |
.agents/skills/agent-conduct/SKILL.md |
Updates conduct guidance. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3168 +/- ##
========================================
Coverage 63.97% 63.97%
========================================
Files 17 17
Lines 9151 9151
========================================
Hits 5854 5854
Misses 3297 3297
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
A recorded local strict-review pass covers head |
Owner
Author
|
Answering the Copilot round on e01150a, whose headline flagged three things without opening a thread: remaining incidental counts, a grammar error, and incomplete fleet-wide cleanup.
|
This was referenced Oct 17, 2026
ptr727
added a commit
that referenced
this pull request
Oct 17, 2026
…3177) ## Summary Removing the incidental count in #3168 left "These kinds of group are never tiered below `frontier`" in `backlog-burndown`, which Copilot flagged on the promotion #3175 as an incorrect singular noun. It now reads "Groups of these kinds are never tiered below `frontier`", which still introduces the bullets that each open on "One touching" or "One whose". The generated distributions are regenerated. ## Verification - `scripts/build_dist.py --check` reports the distributions current. - `prose_lint.py --diff` (default rules and `--check sentence-length`) and markdownlint are clean. - Local strict review: 0 findings. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
ptr727
added a commit
that referenced
this pull request
Oct 17, 2026
…r to Main (#3175) - #3168 adds `GOVERNANCE.md` "Documentation Style Conventions" > "Incidental Counts", carried whole into `comment-and-doc-style`, and removes the incidental counts from the carried canonicals, the skill sources, `scripts/README.md`, and the `scripts/handoff.py` docstring. The rest of the sweep is #3169. - #3172 teaches `pr_review.py` Copilot's count-first overview summaries, `N previously missed issues`, `N open issue(s)`, and the `**No open issues**` stated zero, which each stopped the loop with exit 43. It reads a section heading's count in one place and reports a vetted previously-missed summary no reader finds. Its deferred local-review findings are #3173 and #3174. - #3177 names the never-tiered-down groups in `backlog-burndown` in the plural, the noun Copilot flagged on this promotion's first round. After this merges, `comment-and-doc-style` changes, so this machine's installed Skills are refreshed at release. Closes #3160 Closes #3167 Closes #3170 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #3160.
GOVERNANCE.md"Documentation Style Conventions" > "Incidental Counts". Text refers to an enumeration ("the following checks", "each case", "the rows below") rather than stating its size. The rule says outright that it holds in every fleet repository, for docs, code and workflow comments, and docstrings. A count stays only where the number is what the reader needs, such as a limit, a threshold, or a measured result, and it then names its source. A wrong incidental count is removed rather than corrected.comment-and-doc-stylecarries the subsection whole as a generated include under "Quantitative claims", and its description gains a trigger for text that states how many items a list holds.fleet-code-reviewgains one line: a finding that a stated count is wrong suggests removing it where it is incidental.AGENTS.md,GOVERNANCE.md,CODESTYLE.md,WORKFLOW.md, the skill sources, and the hub-onlyscripts/README.mdandscripts/handoff.pydocstring, which repeated one of the same sentences.Deliberately left as they are:
.editorconfigand.gitattributespair.CODESTYLE.md"General" andpr-review-conductare unchanged, since theGOVERNANCE.mdsection already governs code comments and the rule itself states how a wrong count is fixed.Verification
scripts/build_dist.py --check,scripts/prose_lint.py --diff,scripts/repo_gate.py --check eol,spec/validate.py: clean.scripts/docker_lint.py: clean.python3 -m unittest discover -s tests: 2887 tests OK, 7 skipped.sentence-lengthcheck reports only sentences that were over the cap before this branch and sit on a touched one-line paragraph. None of them is new wording.local-strict-reviewran three recorded passes. The first raised 14 findings and the second raised 1, almost all antecedents left dangling by a removed count. All were fixed, and the final pass raised none.🤖 Generated with Claude Code