Repository navigation
Exempt nopep8 as a Leading Directive in the Prose Gate - #2833
Merged
Merged
Conversation
NOT_PROSE named noqa but not nopep8, so a leading nopep8 directive line holding two sentences was judged by comment-wrap and comment-case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
NOT_PROSE now exempts nopep8 from every comment rule, as it does noqa, so the TOOL_DIRECTIVE entry could never be reached. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Add regression coverage for lowercase leading # nopep8 spelling.
1 open finding
What changed in this PR
Updates the prose gate so leading nopep8 directives receive the same exemption as noqa.
Changes:
- Adds case-insensitive
nopep8matching toNOT_PROSE. - Removes the redundant
TOOL_DIRECTIVEalternative. - Adds regression coverage for directive exemptions.
| File | Summary |
|---|---|
tests/test_prose_lint.py |
Adds nopep8 exemption coverage; lowercase spelling coverage is still needed. |
.github/actions/prose-gate/prose_lint.py |
Updates directive classification patterns. |
🧠 Review effort: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2833 +/- ##
========================================
Coverage 60.26% 60.26%
========================================
Files 16 16
Lines 8489 8489
========================================
Hits 5116 5116
Misses 3373 3373
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
Author
|
A recorded local strict-review pass covers head |
ptr727
added a commit
that referenced
this pull request
Oct 11, 2026
…ilure Reporting Fixes to Main (#2816) ## Summary Promotes these pull requests from develop to main: - #2832 Require Every CLI Script to Answer Help and Refuse Unknown Arguments - #2833 Exempt nopep8 as a Leading Directive in the Prose Gate - #2815 Bind the Workspace-Edit Rule Only to an Agent Running Inside VS Code - #2813 Record HomeAssistant-Config's Incidental Python as a driftNote - #2827 Read nopep8 in Any Letter Case in the Prose Gate - #2825 Spend a Head Refusal a Later Genuine Round on That Head Answers - #2819 Read noqa and CSpell Directives in Any Letter Case - #2814 Judge the Prose in Front of a Trailing noqa or pylint Directive - #2811 Name Why a Windows Tool Install Failed and Print Docker's Status in UTF-8 - #2808 Read a Tool Name as a Prose Gate Directive Only Where It Opens the Comment - #2802 Name a File the Prose Gate Cannot Decode in Its Scope Line - #2800 Read a First-Line Comment After a Byte Order Mark as Leading in Every Language - #2797 Name a Python File the Prose Gate Cannot Parse in Its Scope Line - #2794 Let the Unattended Orchestrator Retry a Transient Dispatch Failure - #2792 Close the Remaining Blocked-Promotion Gaps in the Unattended Worker - #2790 Read a Carried Change Set Past the Compare Endpoint's 300-File Ceiling - #2784 Let a Round on the Head Outrank pr_review.py wait's Repo-Wide Quota Reading - #2782 Say What pr_review.py wait --min-rounds Counts and Name It at the Timeout - #2778 Share the Bounded Step Reader Across the Test Harnesses - #2776 Pin the Prose Gate's Override Wiring by Structure - #2773 Exempt a List Item's Label Separator from the Dash Rule for Every Marker and Bold Spelling - #2771 Strip a List Item's Opening Label for Every Marker and Bold Spelling in the Prose Gate - #2768 Page pr_review.py's Changed-File List Past 100 So a Large Promotion Can State Coverage - #2765 Let an Attested Local Pass Cover a Head Beside a Table-Less Copilot Round Closes #2285 Closes #2820 Closes #2818 Closes #2809 Closes #2807 Closes #1659 Closes #2796 Closes #2798 Closes #2163 Closes #1984 Closes #2614 Closes #2767 Closes #2781 Closes #2741 Closes #2775 Closes #1665 Closes #2770 Closes #2738 Closes #2758 Closes #2739 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
nopep8(any letter case) to the prose gate'sNOT_PROSEpattern besidenoqa, so a comment line opening on it is exempt from comment-wrap, comment-case and comment-added exactly asnoqais. Removes thenopep8alternative fromTOOL_DIRECTIVE, which was unreachable onceNOT_PROSEis tested first.This answers an open Copilot finding on the develop to main promotion PR.
Known items, each with its class:
nopep8exemption gives up the sentence-end guardis_tool_directiveapplied, and is not limited to Python files. This matches hownoqaalready behaves (intended parity, not a regression).# nopep8spelling for comment-case (introduced, minor; the existing rows are capitalised).Closes on promotion: none (finding on the promotion PR only).
🤖 Generated with Claude Code