Skip to content

Bind the Workspace-Edit Rule Only to an Agent Running Inside VS Code - #2815

Merged
ptr727 merged 3 commits into
developfrom
feature/workspace-edit-vscode-only
Oct 11, 2026
Merged

ptr727 merged 3 commits into
developfrom
feature/workspace-edit-vscode-only

Conversation

@ptr727

@ptr727 ptr727 commented Oct 11, 2026

Copy link
Copy Markdown
Owner

Summary

The rule against editing a loaded .code-workspace file applied wherever the editing agent ran, so agents in a standalone console kept handing trivial workspace edits back to the maintainer. A VS Code reload drops only a session that VS Code hosts. The rule now binds an agent running inside VS Code, in its extension or its integrated terminal, and an agent in a standalone console edits the file directly, even while a window has it loaded.

  • GOVERNANCE.md "Verification Discipline": scopes the rule to an agent hosted by VS Code. It keeps the exemption for a file no window has loaded, and asks the maintainer only when the agent cannot tell whether the rule binds it.
  • GOVERNANCE.md "Editor and Tasks": the pointer bullet now states the same split.
  • agent-conduct Skill: regenerated, since it carries "Verification Discipline" as an include.

Verification

  • scripts/build_dist.py --check reports the generated distributions are current.
  • prose_lint.py --diff against the merge base reports no violations.
  • spec/validate.py passes.
  • The markdownlint container reports 0 errors.
  • Three recorded local-strict-review passes ran. The first two raised findings: the dropped not-loaded exemption, an unreliable environment-variable sign, and an over-broad fallback. Each was fixed. The final pass raised none.

🤖 Generated with Claude Code

ptr727 and others added 3 commits October 11, 2026 08:27
A workspace reload drops only a session that VS Code hosts, so an agent
running in a standalone console now edits a .code-workspace directly,
even while a window has that file loaded.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…Rule

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 11, 2026 15:30
@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7815c791-3f6b-449d-bbf5-cc836e1090c9

📥 Commits

Reviewing files that changed from the base of the PR and between cb4abd7 and c9e1d29.


⛔ Files ignored due to path filters (3)
  • .claude-plugin/fleet-skills/.source-digests/agent-conduct is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/skills/agent-conduct/SKILL.md is excluded by !.claude-plugin/fleet-skills/**
  • .github/skills/agent-conduct/SKILL.md is excluded by !.github/skills/**

📒 Files selected for processing (2)
  • .agents/skills/agent-conduct/SKILL.md
  • GOVERNANCE.md

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@ptr727

ptr727 commented Oct 11, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@codecov

codecov Bot commented Oct 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@cb4abd7). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2815   +/-   ##
==========================================
  Coverage           ?   60.30%           
==========================================
  Files              ?       16           
  Lines              ?     8479           
  Branches           ?        0           
==========================================
  Hits               ?     5113           
  Misses             ?     3366           
  Partials           ?        0           
Flag Coverage Δ
python-3.13 60.30% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727
ptr727 merged commit 5bfd54c into develop Oct 11, 2026
13 of 14 checks passed
@ptr727
ptr727 deleted the feature/workspace-edit-vscode-only branch October 11, 2026 17:59
@ptr727

ptr727 commented Oct 11, 2026

Copy link
Copy Markdown
Owner Author

Post-merge review, recorded as coverage evidence for promotion #2816, since this pull request's only Copilot round was a quota refusal.

A frontier-tier, read-only review read all 5 changed files at develop 4035555, plus every other surface that states the rule. It raised one defect and one nit, and the maintainer accepted both as tracked rather than blocking. Both are filed as #2834. The defect is that the console exemption permits an edit that reloads a window hosting another agent session. The nit is that the "Editor and Tasks" closing sentence is now over-general. The generated agent-conduct copies are byte-identical to the source, and no other surface states the rule.

ptr727 added a commit that referenced this pull request Oct 11, 2026
…ilure Reporting Fixes to Main (#2816)

## Summary

Promotes these pull requests from develop to main:

- #2832 Require Every CLI Script to Answer Help and Refuse Unknown
Arguments
- #2833 Exempt nopep8 as a Leading Directive in the Prose Gate
- #2815 Bind the Workspace-Edit Rule Only to an Agent Running Inside VS
Code
- #2813 Record HomeAssistant-Config's Incidental Python as a driftNote
- #2827 Read nopep8 in Any Letter Case in the Prose Gate
- #2825 Spend a Head Refusal a Later Genuine Round on That Head Answers
- #2819 Read noqa and CSpell Directives in Any Letter Case
- #2814 Judge the Prose in Front of a Trailing noqa or pylint Directive
- #2811 Name Why a Windows Tool Install Failed and Print Docker's Status
in UTF-8
- #2808 Read a Tool Name as a Prose Gate Directive Only Where It Opens
the Comment
- #2802 Name a File the Prose Gate Cannot Decode in Its Scope Line
- #2800 Read a First-Line Comment After a Byte Order Mark as Leading in
Every Language
- #2797 Name a Python File the Prose Gate Cannot Parse in Its Scope Line
- #2794 Let the Unattended Orchestrator Retry a Transient Dispatch
Failure
- #2792 Close the Remaining Blocked-Promotion Gaps in the Unattended
Worker
- #2790 Read a Carried Change Set Past the Compare Endpoint's 300-File
Ceiling
- #2784 Let a Round on the Head Outrank pr_review.py wait's Repo-Wide
Quota Reading
- #2782 Say What pr_review.py wait --min-rounds Counts and Name It at
the Timeout
- #2778 Share the Bounded Step Reader Across the Test Harnesses
- #2776 Pin the Prose Gate's Override Wiring by Structure
- #2773 Exempt a List Item's Label Separator from the Dash Rule for
Every Marker and Bold Spelling
- #2771 Strip a List Item's Opening Label for Every Marker and Bold
Spelling in the Prose Gate
- #2768 Page pr_review.py's Changed-File List Past 100 So a Large
Promotion Can State Coverage
- #2765 Let an Attested Local Pass Cover a Head Beside a Table-Less
Copilot Round

Closes #2285
Closes #2820
Closes #2818
Closes #2809
Closes #2807
Closes #1659
Closes #2796
Closes #2798
Closes #2163
Closes #1984
Closes #2614
Closes #2767
Closes #2781
Closes #2741
Closes #2775
Closes #1665
Closes #2770
Closes #2738
Closes #2758
Closes #2739

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants