Smoke-Build a Dispatched Run of the Smoke Caller Snippet Past Its Paths Filter #3149

Context

Raised by CodeRabbit on the develop -> main promotion #3146, against catalog/snippets/workflows/test-pull-request-smoke.yml, which #3113 added. The YAML is older than that file: main's docs/reusable-workflows.md "Release repos with a smoke build" example already carries the same workflow_dispatch: trigger and the same if: needs.changes.outputs.release == 'true' gate on smoke-build, and #3113 copied that example into the catalog, where develop's doc still carries it.

Gap

On a workflow_dispatch run there is no pull request, so dorny/paths-filter compares against a base it picks itself. A dispatch on the default branch compares only that branch's last commit. Where that commit touches no release path, smoke-build skips, and check-workflow-status reads the skip as a pass, so a manual run meant to smoke-build the target builds nothing and reports green.

Possible Direction

Let a dispatch bypass the filter, if: github.event_name == 'workflow_dispatch' || needs.changes.outputs.release == 'true', in the snippet and the docs example together, or drop workflow_dispatch: from the pull request workflow where a dispatch has no use. WORKFLOW.md D1.1 states the filter for a pull request only, so either choice keeps the contract. Which one the fleet wants is the maintainer's call.