Skip to content

Carried .gitattributes and .markdownlint-cli2.jsonc Comments Exceed the Sentence-Length Limit #2845

Closed

Description

@ptr727

Observed

At hub main 50b6bc37 (2.0.972), scripts/prose_lint.py --check sentence-length flags three comment lines in carried config canonicals:

  • .gitattributes:1: 29 words in one sentence
  • .gitattributes:2: 26 words in one sentence
  • .markdownlint-cli2.jsonc:24: 33 words in one sentence

The hub's own gate is diff-scoped, so it never reports these lines in the hub. They show up wherever the canonical is carried, because a resync re-adds them as changed lines. Copilot flagged the two .gitattributes lines as "two comment-length nits remain" in the verdict headline of ptr727/VSCode-Server-DotNetCore#152, which carries both files byte-identical to the hub.

Expected vs. actual

  • Expected: carried canonical comments pass the sentence-length rule the hub now applies to comments (Extend the Sentence-Length Check to Comments and Docstrings #2836), so a resync does not carry new findings into every repository.
  • Actual: each resync of these files re-raises the same findings in the carrying repository, which cannot fix them without diverging from the canonical.

What done looks like

The three comments are split into sentences of 25 words or fewer in the hub canonical, and a resync carries the fix.

Activity

  1. added a commit that references this issue on Oct 11, 2026
    722a040
  2. added a commit that references this issue on Oct 12, 2026
    687d5bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions