You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Session Handoff [engineering]: #2430 and #2750 Released as 2.0.972, #2839 and #2838 Next #2841
pr_review.py wait Matches a Required Check by Name Alone, Ignoring the Rule's integration_id #2839, pr_review.py wait matches a required check by name alone. The ruleset entry carries an integration_id, and a same-name check from another app satisfies the hold today. Done means a rollup node satisfies an entry with an integration_id only when its app matches, with a test for the same-name, different-app case.
#1814 (skill files hard-wrap) is still open and is left to the unattended loop's picker. #2830 tracks a diff-floor test that fails on a clean develop when run from some working directories, and CI passes it.
External blockers
Nothing in the next steps waits on the maintainer.
CodeRabbit still posts only its low-star notice here. Copilot plus the attested local pass covered this round.
The primary checkout is on develop, fast-forwarded. Both lane worktrees, their local and remote branches, and the detached skills-refresh worktree are removed.
The installed Skills snapshot reads current at the promoted main, and the host-safety kit reads CURRENT.
The decision queue held zero open issues when this link was written.
A worker's decline reply that overstates what the code guarantees. Read each decline a lane reports for claims beyond the design ruling, and correct it on the thread before the promotion opens, since the promotion's reviewer raises the same gap again.
The maintainer chose to merge and release #2840 when asked during this round. It merged as 50b6bc3 and was released as 2.0.972. The parked decision queue held zero open decision issues when this link was written, so no questions were owed at close.
Next steps, in priority order
pr_review.py waitmatches a required check by name alone. The ruleset entry carries anintegration_id, and a same-name check from another app satisfies the hold today. Done means a rollup node satisfies an entry with anintegration_idonly when its app matches, with a test for the same-name, different-app case.Args:bodies, bullet and numbered markers counted as words, a closing quote on a docstring's last code line, and docstring boundaries inferred from quotes. Done means each listed case is handled or explicitly ruled out on the issue.#1814 (skill files hard-wrap) is still open and is left to the unattended loop's picker. #2830 tracks a diff-floor test that fails on a clean develop when run from some working directories, and CI passes it.
External blockers
Internal dependencies
scripts/pr_review.pyand.github/actions/prose-gate/prose_lint.py), so they can run as parallel lanes again.State
decisionqueue held zero open issues when this link was written.The parked decision queue
Zero open
decisionissues.What the last round did
prose_lint.py's opt-insentence-lengthcheck now reads code comments outside Markdown and Python docstrings, through one counting helper shared with the Markdown reader, scoped to changed lines. The comment prose filters are now shared withcomment-wrap.waitholds an attested head while a check the base branch's rules require is absent from the rollup. An unreadable rules read keeps the old behavior and prints a note.attestwaits up to 60 seconds for a push GitHub has not registered, only where the remote branch already holds the checkout's commit.standardlanes from one shared brief plus a per-lane design ruling, then one promotion, Promote the Comment and Docstring Sentence-Length Check and the Attested Wait Hold to Main #2840. Its only finding was the pr_review.py wait Matches a Required Check by Name Alone, Ignoring the Rule's integration_id #2839 gap, answered as a deferral.CHECKS_PENDING, which the code does not guarantee. A correction was posted under it, pointing at pr_review.py wait Matches a Required Check by Name Alone, Ignoring the Rule's integration_id #2839.What not to repeat
pr_review.py waitreturn at once while only a Windows unit-test check was pending. It ran the pre-Hold an Attested Wait Until the Base Branch's Required Checks Register #2837 script from its own checkout. Check whether Hold an Attested Wait Until the Base Branch's Required Checks Register #2837's required-check hold covers that case before filing it, since the required aggregator waits behind that job.New learnings