Repository navigation
Keep Dot Directories Out of Lint Ownership and Update Two Operations Notes - #265
Conversation
|
A recorded local strict-review pass covers head |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #265 +/- ##
===========================================
+ Coverage 84.12% 84.36% +0.24%
===========================================
Files 3 3
Lines 611 614 +3
===========================================
+ Hits 514 518 +4
+ Misses 97 96 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
The ownership fallback can still classify matching files under dot directories as repository-owned.
1 open issue
What changed in this PR
This pull request updates compile-lint ownership handling for dot-directory paths and documents two operational safety considerations. An unresolved ownership fallback issue remains for matching files under excluded directories.
Changes:
- Excludes dot-directory paths from direct repository ownership classification.
- Adds regression coverage for
.esphomebuild artifacts. - Documents the unauthenticated CoreS3 camera endpoint.
- Updates guidance for the hub’s isolated Docker lint snapshot workflow.
| File | Summary |
|---|---|
tools/compile-lint/src/compile_lint/lint.py |
Filters dot-directory paths during ownership resolution; the content-hash fallback still requires correction. |
tests/compile_lint/test_lint.py |
Verifies that generated files under .esphome are not treated as repository-owned. |
OPERATIONS.md |
Documents camera network-safety guidance and the safe lint-container snapshot workflow. |
Review effort: Lite

Answers the remaining findings from the develop -> main promotion review.
uvxroute the build tree sits in.esphome/buildand fetched packages in.esphome/packages, so their diagnostics were reported as owned. A package there now takes the remote-package route. The new test fails without the change.docker_lint.pycannot take a snapshot and must not be used. The wrapper on the hub'smainstages its own snapshot fromgit ls-files --cached --others --exclude-standardand mounts only that, read-only with networking off, sosecrets.yamlnever reaches a container. The note now says so.Unit tests, ruff, pyright, markdownlint and the prose gate pass locally.
🤖 Generated with Claude Code