Skip to content

Keep Dot Directories Out of Lint Ownership and Update Two Operations Notes - #265

Merged
ptr727 merged 2 commits into
developfrom
feature/lint-ownership-and-docs
Oct 25, 2026
Merged

ptr727 merged 2 commits into
developfrom
feature/lint-ownership-and-docs

Conversation

@ptr727

@ptr727 ptr727 commented Oct 25, 2026

Copy link
Copy Markdown
Owner

Answers the remaining findings from the develop -> main promotion review.

  • The compile lint treats a path inside a dot directory under the config root as not this repository's code. On the uvx route the build tree sits in .esphome/build and fetched packages in .esphome/packages, so their diagnostics were reported as owned. A package there now takes the remote-package route. The new test fails without the change.
  • OPERATIONS.md notes that the CoreS3 example's camera snapshot endpoint has no authentication, so the example belongs on a bench network.
  • OPERATIONS.md's lint-container note said the hub's docker_lint.py cannot take a snapshot and must not be used. The wrapper on the hub's main stages its own snapshot from git ls-files --cached --others --exclude-standard and mounts only that, read-only with networking off, so secrets.yaml never reaches a container. The note now says so.

Unit tests, ruff, pyright, markdownlint and the prose gate pass locally.

🤖 Generated with Claude Code

@ptr727 ptr727 added the comments Permits the comment lines the pull request adds or edits, which the prose gate otherwise refuses label Oct 25, 2026
Copilot AI lite review requested due to automatic review settings October 25, 2026 17:01
@ptr727

ptr727 commented Oct 25, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 32b8c2c7ebe2436fc31e7d9c5ec21e8e0b41b8b3, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 74b3e6cf-63af-4c7c-bed7-d6e2d6446fea
Commits

Reviewing files that changed from the base of the PR and between c253a05 and 32b8c2c.

Files selected for processing: 3
  • OPERATIONS.md
  • tests/compile_lint/test_lint.py
  • tools/compile-lint/src/compile_lint/lint.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.36%. Comparing base (c253a05) to head (32b8c2c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #265      +/-   ##
===========================================
+ Coverage    84.12%   84.36%   +0.24%     
===========================================
  Files            3        3              
  Lines          611      614       +3     
===========================================
+ Hits           514      518       +4     
+ Misses          97       96       -1     
Flag Coverage Δ
python-3.13 84.36% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The ownership fallback can still classify matching files under dot directories as repository-owned.

1 open issue
What changed in this PR

This pull request updates compile-lint ownership handling for dot-directory paths and documents two operational safety considerations. An unresolved ownership fallback issue remains for matching files under excluded directories.

Changes:

  • Excludes dot-directory paths from direct repository ownership classification.
  • Adds regression coverage for .esphome build artifacts.
  • Documents the unauthenticated CoreS3 camera endpoint.
  • Updates guidance for the hub’s isolated Docker lint snapshot workflow.
File Summary
tools/​compile-lint/​src/​compile_lint/​lint.py Filters dot-directory paths during ownership resolution; the content-hash fallback still requires correction.
tests/​compile_lint/​test_lint.py Verifies that generated files under .esphome are not treated as repository-owned.
OPERATIONS.md Documents camera network-safety guidance and the safe lint-container snapshot workflow.

Review effort: Lite

Comment thread tools/compile-lint/src/compile_lint/lint.py
@ptr727
ptr727 merged commit 59c44d4 into develop Oct 25, 2026
38 checks passed
@ptr727
ptr727 deleted the feature/lint-ownership-and-docs branch October 25, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comments Permits the comment lines the pull request adds or edits, which the prose gate otherwise refuses

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants