[ptr727]

Fixes two findings the hosted review raised on the develop -> main promotion pull request.

• check-workflow-status blocks any template-compile-test result other than success or skipped. A cancelled leg, which the new lint step can produce, otherwise passed the required check.
• The compile lint confines every inline match to the occurrence whose span holds the diagnostic's column, not only an args: entry's. A warning elsewhere on a line that also carries a lambda's expression is no longer attributed to that lambda. The new test fails without the fix.

Verified against a fresh CoreS3 build: each inlined line still lands on its YAML entry, and the same lines at a column outside the expression are set aside. Unit tests, ruff, pyright, actionlint and the prose gate pass.

🤖 Generated with Claude Code

[ptr727]

A recorded local strict-review pass covers head 22e4bbb401346fb7cb314d085c733eab743de062, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 49 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 2ac1d325-d778-4da3-af7b-d6e28f6412e6

Commits

Reviewing files that changed from the base of the PR and between 337ef0d and 22e4bbb.

Files selected for processing: 3

• .github/workflows/test-pull-request.yml
• tests/compile_lint/test_lint.py
• tools/compile-lint/src/compile_lint/lint.py

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.12%. Comparing base (337ef0d) to head (22e4bbb).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #264      +/-   ##
===========================================
- Coverage    84.17%   84.12%   -0.06%     
===========================================
  Files            3        3              
  Lines          613      611       -2     
===========================================
- Hits           516      514       -2     
  Misses          97       97              

Flag	Coverage Δ
python-3.13	84.12% <100.00%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

🟢 Approval recommended

All reviewed changes have no unresolved findings and the supplied assessments unanimously support approval.

No open issues 🎉

What changed in this PR

This pull request hardens compile-lint diagnostic attribution and prevents cancelled template compile jobs from satisfying the required workflow check.

Changes:

• Require template-compile-test to conclude with success or skipped.
• Restrict inline diagnostic matches to the expression span containing the diagnostic column.
• Add regression coverage for multiple inline expressions on one generated line.

File	Description
tools/​compile-lint/​src/​compile_lint/​lint.py	Restricts inline findings to the matching expression span.
tests/​compile_lint/​test_lint.py	Verifies diagnostics are not attributed to unrelated inline expressions.
.github/​workflows/​test-pull-request.yml	Blocks cancelled or otherwise unsuccessful compile-test results.

_{Review effort: Lite}