Repository navigation
Gate the CeilSense Boot LED on the Vendor's Self-Test Switch - #240
Conversation
The vendor made its startup LED self-test opt-in, gating both the phase 1 loading effect and the final turn-off on the Startup LED Self-Test switch. The template's stand-in for the unimported wifi.yaml phase 1 still turned the effect on unconditionally, so with the switch off nothing turned it off and the ring kept spinning after boot. Phase 1 now checks the same switch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #240 +/- ##
========================================
Coverage 43.07% 43.07%
========================================
Files 1 1
Lines 130 130
========================================
Hits 56 56
Misses 74 74
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
The focused change matches the described vendor behavior, has compile and device verification, and has no unresolved findings.
0 open findings
What changed in this PR
This change keeps the CeilSense boot LED behavior aligned with the vendor’s opt-in self-test switch, so the loading effect does not remain on when the switch is off.
Changes:
- Gates the boot loading effect on
Startup LED Self-Test. - Updates the nearby comment to describe that condition.
| File | Description |
|---|---|
templates/smarthome-ceilsense.yaml |
Adds the switch condition to the boot LED action. |
🧠 Review effort: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Fixes the garage CeilSense status LED ring spinning blue after boot.
Changes
Startup LED Self-Testswitch, which defaults off. Itswifi.yamlphase 1 turns the loading effect on only while the switch is on, andbase.yamlturns the LED off at the end of boot only while it is on.light.turn_onis now gated onswitch.is_on: startup_led_test_enabled, matching the vendor.@main, so the 2.3 build was the first to pick the vendor change up.Verification
esphome configandesphome compileofgarage-presence-sensor.yamlpass on ESPHome 2026.9.1, the dashboard's version.offin Home Assistant, where before the flash it stayedonwith theCircular Loading Effect.94adcec: the sentence-length check passes, and the default check passes with--allow-comments.🤖 Generated with Claude Code
Summary by CodeRabbit