Add setting to force all site visitors to login via AAD#132
Open
ccardinaux wants to merge 2 commits intopsignoret:masterfrom
Open
Add setting to force all site visitors to login via AAD#132ccardinaux wants to merge 2 commits intopsignoret:masterfrom
ccardinaux wants to merge 2 commits intopsignoret:masterfrom
Conversation
bradkovach
reviewed
May 4, 2017
| public function save_redirect_and_force_login() { | ||
|
|
||
| $this->register_session(); | ||
|
|
Contributor
There was a problem hiding this comment.
This might fail if the server is running on a non-standard port... Check this approach https://gist.github.com/leereamsnyder/fac3b9ccb6b99ab14f36
Author
There was a problem hiding this comment.
Good point, thanks for the feedback.
bradkovach
approved these changes
May 24, 2017
Contributor
bradkovach
left a comment
bradkovach
left a comment
There was a problem hiding this comment.
Looks good. Paging @psignoret for more feedback.
psignoret
force-pushed
the
master
branch
2 times, most recently
from
0320183 to
37c8428
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Philippe,
Thanks for the great plugin! Added a new option to force all site visitors to login via Azure before accessing the site. Would appreciate any edits/comments you have.
Thanks,
Charles