Additions to pull realName, email and potentially URI from LDAP#1
Open
make-all wants to merge 5 commits intopsigen:masterfrom
Open
Additions to pull realName, email and potentially URI from LDAP#1make-all wants to merge 5 commits intopsigen:masterfrom
make-all wants to merge 5 commits intopsigen:masterfrom
Conversation
In particular, configuring kerberos authentication alongside LDAP authorization for combined environments like Active Directory, and passing additional info from LDAP in the authorization phase, which we can now use in this extension to provide more than just username.
In https://secure.phabricator.com/D21014 the underlying PhabricatorAuthProvider API was changed, and we need to change the function we call to finish authentication and register a new user if necessary.
The Adapter base class has a method for this, and the upstream has used it for some time. This should have been failing since earlier, unless multiple changes upstream were all done together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code changes should be transparent on environments that cannot use them. The doc changes explain how to set this up. If you choose to pull back into your version, you probably want to leave out the gratuitous git URL change on line 15/17.