docs: fix incomplete tab panel snippet in cookbook#13
Merged
Conversation
Complete the truncated effect to toggle panel visibility via context $active, matching the working tabs example. Drop unused register field from TabsAPI so the snippet type-checks. Closes #12
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a broken TypeScript snippet in the "Child needs parent state or API" cookbook section of the docs.
Problem Statement
The cookbook example for context-driven parent-child communication had a truncated line (
ctx.host.setAttribute('aria-)), reported in #12. A reader copying the snippet would hit a syntax error. The same snippet also declared aregisterfield onTabsAPIthat was never provided, so it wouldn't type-check.Solution Approach
$activevalue (ctx.host.hidden = active !== ctx.props.$value.get()), matching the canonical workingtabs.htmlexample.registerfield fromTabsAPIso the parent'sprovide()call and the type agree.Closes #12