Skip to content

docs: use prop atoms directly in counter and tabs examples #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psd-coder merged 2 commits into from
Jun 22, 2026
Merged

docs: use prop atoms directly in counter and tabs examples #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec0bf34
docs: use prop atom directly in tabs example
psd-coder Jun 22, 2026
8f45443
docs: use prop atom directly in counter example
psd-coder Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions apps/docs/src/content/examples/counter.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

<body>
<div data-type="html">
<x-counter initial="1" step="5">
<x-counter value="1" step="5">
<div>
<input data-ref="stepInput" type="range" min="1" max="50" value="5">
<span>Step: <span data-ref="step">5</span></span>
Expand All @@ -31,7 +31,6 @@

<script type="module" data-type="javascript">
import { define } from 'nanotags';
import { atom } from 'nanostores';

define('x-counter')
.withRefs(({ one }) => ({
Expand All @@ -41,14 +40,12 @@
increment: one('button'),
count: one('span')
}))
.withProps((p) => ({ initial: p.number(), step: p.number(5) }))
.withProps((p) => ({ value: p.number(), step: p.number(5) }))
.setup((ctx) => {
const $count = atom(ctx.props.$initial.get());

ctx.bind(ctx.props.$step, ctx.refs.stepInput);
ctx.on(ctx.refs.increment, 'click', () => $count.set($count.get() + ctx.props.$step.get()));
ctx.on(ctx.refs.decrement, 'click', () => $count.set($count.get() - ctx.props.$step.get()));
ctx.effect($count, (val) => {
ctx.on(ctx.refs.increment, 'click', () => ctx.props.$value.set(ctx.props.$value.get() + ctx.props.$step.get()));
ctx.on(ctx.refs.decrement, 'click', () => ctx.props.$value.set(ctx.props.$value.get() - ctx.props.$step.get()));
ctx.effect(ctx.props.$value, (val) => {
ctx.refs.count.textContent = String(val);
console.log('Count changed:', val);
});
Expand Down
12 changes: 5 additions & 7 deletions apps/docs/src/content/examples/tabs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ <h3>Setup</h3>
<script type="module" data-type="javascript">
import { define } from "nanotags";
import { createContext } from "nanotags/context";
import { atom } from "nanostores";
import { attachRovingFocus } from "attachRovingFocus.js";

const tabsContext = createContext("tabs");
Expand All @@ -60,22 +59,21 @@ <h3>Setup</h3>
tabs: r.many("[role=tab]")
}))
.setup((ctx) => {
const $active = atom(ctx.props.$active.get());

// ctx.props.$active is already a WritableAtom, so use it directly as state.
attachRovingFocus(ctx, ctx.refs.tablist, ctx.refs.tabs, {
onFocus: (el) => $active.set(el.dataset.value),
onFocus: (el) => ctx.props.$active.set(el.dataset.value),
});

ctx.on(ctx.refs.tabs, "click", (e) => $active.set(e.target.dataset.value));
ctx.effect($active, (active) => {
ctx.on(ctx.refs.tabs, "click", (e) => ctx.props.$active.set(e.target.dataset.value));
ctx.effect(ctx.props.$active, (active) => {
ctx.refs.tabs.forEach((tab) => {
const selected = tab.dataset.value === active;
tab.setAttribute("aria-selected", String(selected));
tab.setAttribute("tabindex", selected ? "0" : "-1");
});
});

tabsContext.provide(ctx, { $active });
tabsContext.provide(ctx, { $active: ctx.props.$active });
});

define("x-tab-panel")
Expand Down
Loading