Stamp release version onto published CLI binaries#20
Merged
Conversation
The AOT publish step never received -p:Version, so the CLI binaries shipped with the placeholder 0.1.0 from Age.Cli.csproj regardless of the release tag. Pass the tag-derived version through, matching the NuGet pack step. Verified the override lands in the assembly's informational version.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
=======================================
Coverage 91.28% 91.28%
=======================================
Files 42 42
Lines 2443 2443
Branches 322 322
=======================================
Hits 2230 2230
Misses 154 154
Partials 59 59 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AOT
dotnet publishstep inpublish.ymlnever received-p:Version, so the CLI binaries in every release shipped stamped with the placeholder0.1.0fromAge.Cli.csproj, regardless of the tag. The NuGetpackstep already threads the tag-derived version through; this does the same for the binary publish.Verified locally that
-p:Version=<x>lands in the produced assembly's informational version (0.2.0-preview.99+<sha>) with no stale0.1.0remaining.