Use a cryptographic RNG for auto-generated passphrases#17
Merged
Conversation
System.Random is predictable; the generated passphrase is the sole secret protecting the encrypted file.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 91.99% 92.03% +0.04%
==========================================
Files 41 41
Lines 2385 2385
Branches 312 312
==========================================
+ Hits 2194 2195 +1
+ Misses 133 132 -1
Partials 58 58 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
age -pwith an empty passphrase auto-generates the passphrase that becomes the file's sole secret — but it was drawn fromSystem.Random, a non-cryptographic PRNG whose output is predictable from a little observed data. Switch toRandomNumberGenerator.GetInt32.Same passphrase format (10 groups of 6 lowercase letters), so this only changes the entropy source; nothing about the file format or CLI surface changes, and only passphrases generated after this commit are affected.
Ported from the
security-hardeningbranch (PR #1, commit cacd850). Full suite green (363 unit + 143 CCTV).