Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces custom shell scripts for dependency management with the west tool, updating the Makefile and requirements.txt while removing the obsolete scripts. Feedback indicates that the transition is currently incomplete as it lacks a west.yml manifest and workspace initialization logic, which will cause build failures. Additionally, it is recommended to pin the version of west in requirements.txt to ensure build reproducibility.
| west update lng_src | ||
|
|
||
| download_lwNBD: | ||
| sh download_lwNBD.sh | ||
| west update lwNBD | ||
|
|
||
| download_cfla: | ||
| sh download_cfla.sh | ||
| west update clang-format-lint-action |
There was a problem hiding this comment.
The transition to west is incomplete and will break the build process. west update requires a west.yml manifest file and an initialized workspace (a .west directory). This PR removes the existing download scripts but does not provide the necessary west.yml file. Additionally, for a seamless developer experience, the Makefile should handle workspace initialization (west init -l .) if it hasn't been performed yet, as the previous scripts handled the cloning logic automatically.
[ -d .west ] || west init -l .
west update lng_src
download_lwNBD:
[ -d .west ] || west init -l .
west update lwNBD
download_cfla:
[ -d .west ] || west init -l .
west update clang-format-lint-action
| @@ -1 +1,2 @@ | |||
| PyYAML==6.0 | |||
| west | |||
There was a problem hiding this comment.
Pinning the version of west is recommended to ensure build reproducibility across different environments and to prevent potential breakages from future updates to the tool.
west==1.2.0
References
- Pinning dependency versions ensures build reproducibility and prevents unexpected breakages from upstream updates.
479cd28 to
8e3a5a1
Compare
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| CodeStyle | 1 minor |
🟢 Metrics 0 complexity · 0 duplication
Metric Results Complexity 0 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Replacing the download scripts with West.