Skip to content

Small fixes to build Envoy #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jwendell wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Small fixes to build Envoy #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f76bd5
Fix a compiler warning
jwendell Dec 15, 2025
0089fb1
Remove `virtual` from a method that's causing issues to Envoy
jwendell Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/proxy-wasm/context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ class ContextBase : public RootInterface,
const std::shared_ptr<PluginHandleBase> &plugin_handle); // Stream context.
virtual ~ContextBase();

virtual WasmBase *wasm() const { return wasm_; }
WasmBase *wasm() const { return wasm_; }
uint32_t id() const { return id_; }
// The VM Context used for calling "malloc" has an id_ == 0.
bool isVmContext() const { return id_ == 0; }
Expand Down
2 changes: 1 addition & 1 deletion include/proxy-wasm/wasm_vm.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ struct WasmVmIntegration {
virtual proxy_wasm::LogLevel getLogLevel() = 0;
virtual void error(std::string_view message) = 0;
// Allow integrations to handle specific FailStates differently.
virtual void error(FailState fail_state, std::string_view message) { error(message); }
virtual void error(FailState, std::string_view message) { error(message); }
virtual void trace(std::string_view message) = 0;
// Get a NullVm implementation of a function.
// @param function_name is the name of the function with the implementation specific prefix.
Expand Down
Loading