Skip to content

feat: fail fast on wrong password for non-TTY start#10

Merged
dhh1128 merged 1 commit into
provenant-dev:bug-238-witness-loggingfrom
kentbull:bug-238-witness-logging-edit
Jul 9, 2026
Merged

feat: fail fast on wrong password for non-TTY start#10
dhh1128 merged 1 commit into
provenant-dev:bug-238-witness-loggingfrom
kentbull:bug-238-witness-logging-edit

Conversation

@kentbull

@kentbull kentbull commented Jul 8, 2026

Copy link
Copy Markdown
  • Cleaned up many verbose comments.
  • Cleaned up deprecated logfile check.
  • --no-prompt added, which defaults to True when not sys.stdin.isatty() so no prompt comes up even when the passcode is specified but wrong (see setupHby). This closes a gap to make sure fail fast occurs for non-TTY startup even on wrong passcode.
  • Cleaned up ordering of one of the tests, added a second test for the noPrompt behavior on incorrect passcode for encrypted keystore.

# Conflicts:
#	src/keri/cli/common/existing.py
@kentbull kentbull force-pushed the bug-238-witness-logging-edit branch from 29b1b4c to 37eaa73 Compare July 9, 2026 19:19
@dhh1128 dhh1128 merged commit 37eaa73 into provenant-dev:bug-238-witness-logging Jul 9, 2026
@dhh1128

dhh1128 commented Jul 9, 2026

Copy link
Copy Markdown
Member

Folded into bug-238-witness-logging via fast-forward (so this PR shows as merged). One follow-up commit layered on top: 18d563d moves the --logfile deprecation notice to after ogler.reopen(), so Logging to {ogler.path} reports the resolved log path rather than the pre-reopen one. All the fail-fast/--no-prompt changes and the new non-TTY wrong-passcode test are accepted as-is; 13/13 kli command tests pass locally. This propagates up to WebOfTrust#1477.

@kentbull kentbull deleted the bug-238-witness-logging-edit branch July 9, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants