Repository navigation
SPEC-045 Amendment 5: rebuild the expired rogue fixture - #207
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test only; no code changes, no release.
tests/Fixtures/spec045-c2patool027-rogue.pngcarried a rogue CA and signer valid for 30 days, until 2026-11-09 06:38:52 UTC. Since then the file readsInvalid(signingCredential.expired, no time-stamp) instead of a trusted file over an untrusted ingredient. AC3's table row kept passing, because under Amendment 2 nothing below an untrusted report is trusted, so it passed for a reason it was not written for. The Drupal module, which copied the file, went red on it (content_credentials #3636349).composer check: 530 passed, 7 skipped.