Repository navigation
Step 77: SPEC-029 Amendment 1, and a gap in REQUIRE_AI_MARKING - #205
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes only: adds
notes/step-77-spec-029-am1-and-a-policy-gap.mdand its row in theNOTES.mdindex, plus a reference under "Service hardening".It records what #204 settled and what it found along the way:
Invalid. 0.91 refuses it after signing, and the service answered 500. The service now refuses such a request itself, with a 400.REQUIRE_AI_MARKING. A body without theextra_assertionskey was signed with no AI marking, becauserejectAssertions()returned early. The early return and the policy check arrived in the same commit (6445e2d), so the gap was as old as the policy. The note covers why no test or criterion saw it, and how writing AC12 surfaced it.composer check528 passed / 7 skipped;bin/spec-check.php0 errors.