Provide pre-generated lockfiles for Protobuf Rust under Bzlmod. - #29533
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_974008598
branch
3 times, most recently
from
September 1, 2026 01:40
80e7a47 to
b626626
Compare
copybara-service
Bot
changed the title
Cargo.Bazel.lock for Protobuf Rust under Bzlmod.
When Protobuf is consumed as a transitive Bzlmod dependency, rules_rust crate_universe requires non-root modules to supply a pre-generated `lockfile` for `crate.from_specs()` because dynamic repinning across module boundaries is disallowed. See rules_rust enforcement at: https://github.com/bazelbuild/rules_rust/blob/f7f212ad30a58475d6252a8607cf5cdb5f59bbdd/crate_universe/extensions.bzl#L614-L625 Additionally, rules_rust requires `cargo_lockfile` when `lockfile` is specified to avoid `cargo-bazel generate` failures during non-repin evaluation. This change adds `rust/Cargo.Bazel.lock` and `rust/Cargo.lock` and references them in `crate.from_specs()`. PiperOrigin-RevId: 974521277
copybara-service
Bot
force-pushed
the
test_974008598
branch
from
September 1, 2026 15:57
b626626 to
e5deac3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide pre-generated lockfiles for Protobuf Rust under Bzlmod.
When Protobuf is consumed as a transitive Bzlmod dependency, rules_rust
crate_universe requires non-root modules to supply a pre-generated
lockfileforcrate.from_specs()because dynamic repinning acrossmodule boundaries is disallowed. See rules_rust enforcement at:
https://github.com/bazelbuild/rules_rust/blob/f7f212ad30a58475d6252a8607cf5cdb5f59bbdd/crate_universe/extensions.bzl#L614-L625
Additionally, rules_rust requires
cargo_lockfilewhenlockfileisspecified to avoid
cargo-bazel generatefailures during non-repinevaluation.
This change adds
rust/Cargo.Bazel.lockandrust/Cargo.lockandreferences them in
crate.from_specs().