Emit null when serializing unset Google\Protobuf\Value to JSON in pure-PHP runtime. - #29531
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Emit null when serializing unset Google\Protobuf\Value to JSON in pure-PHP runtime.#29531copybara-service[bot] wants to merge 1 commit into
null when serializing unset Google\Protobuf\Value to JSON in pure-PHP runtime.#29531copybara-service[bot] wants to merge 1 commit into
Conversation
…ure-PHP runtime.
Note that this won't perfectly round trip, since on parse-back the `null_value` arm will be set instead, but the common behavior of other impls is to emit `null` for this.
Before this fix, the Pure-PHP JSON implementation would emit malformed JSON by emitting no value,, like `{"someValueField": }`
Note that this actually won't perfectly round-trip (since the parse-back will parse it as a Value with null_value kind). This matches the behavior of our other runtimes.
PiperOrigin-RevId: 973442012
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit
nullwhen serializing unset Google\Protobuf\Value to JSON in pure-PHP runtime.Note that this won't perfectly round trip, since on parse-back the
null_valuearm will be set instead, but the common behavior of other impls is to emitnullfor this.Before this fix, the Pure-PHP JSON implementation would emit malformed JSON by emitting no value,, like
{"someValueField": }Note that this actually won't perfectly round-trip (since the parse-back will parse it as a Value with null_value kind). This matches the behavior of our other runtimes.