Add ForceUppercaseEnums option on JSON unmarshalling options#34
Add ForceUppercaseEnums option on JSON unmarshalling options#34bobbytables wants to merge 1 commit into
Conversation
For systems that send in lowercase enums such as in API requests, this option is helpful to first uppercase the encoded value before doing a lookup for the enum by name.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thank you for your interest into contributing to this project. Unfortunately this project does not accept GitHub pull requests as the source-of-truth for this project is hosted at https://go.googlesource.com/protobuf. This project page on GitHub is a mirror of that other repository. If you would like to contribute to this project, please follow the contribution guidelines for instructions on how to send a change. If the change you'd like to make is more substantial or introduces any new features, then it should first be discussed on the issue tracker. |
|
@bobbytables do you plan to follow up on this? This seems like a great addition to the library. If not, I would like to keep moving this request forward. |
For systems that send in lowercase enums such as in API requests, this option is helpful to first uppercase the encoded value before doing a lookup for the enum by name.
There have been mentions of this in past issues, and I think an unmarshal option is a nice way to give people flexibility on how enums are handled.