Skip to content

[codex] restore ProseMirror-selectednode default#256

Draft
ocavue wants to merge 1 commit into
mainfrom
codex/restore-node-selection-default
Draft

[codex] restore ProseMirror-selectednode default#256
ocavue wants to merge 1 commit into
mainfrom
codex/restore-node-selection-default

Conversation

@ocavue

@ocavue ocavue commented Jul 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Restore ProseMirror's default selected-node class and draggable behavior in CoreNodeView when no custom select handlers are provided.
  • Keep framework selected context updates by wrapping the returned node view instance instead of installing internal selectNode and deselectNode options.
  • Add e2e coverage for .ProseMirror-selectednode and draggable toggling across Lit, Preact, React, Solid, Svelte, and Vue examples.
  • Add a patch changeset for the affected packages.

Root Cause

Framework adapters installed internal selectNode and deselectNode callbacks to rerender selected state. prosemirror-view treats those callbacks as custom node-view overrides, so its default selected-node behavior never ran for adapter node views.

Checks

  • pnpm run build
  • pnpm --filter=e2e build && pnpm --filter=e2e test tests/node-view.spec.ts --project=chromium
  • pnpm run typecheck
  • pnpm run lint
  • pnpm run test

@vercel

vercel Bot commented Jul 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
prosemirror-adapter-e2e Ready Ready Preview, Comment Jul 7, 2026 5:36pm

@pkg-pr-new

pkg-pr-new Bot commented Jul 7, 2026

Copy link
Copy Markdown

Open in StackBlitz

@prosemirror-adapter/core

npm i https://pkg.pr.new/@prosemirror-adapter/core@256

@prosemirror-adapter/lit

npm i https://pkg.pr.new/@prosemirror-adapter/lit@256

@prosemirror-adapter/preact

npm i https://pkg.pr.new/@prosemirror-adapter/preact@256

@prosemirror-adapter/react

npm i https://pkg.pr.new/@prosemirror-adapter/react@256

@prosemirror-adapter/solid

npm i https://pkg.pr.new/@prosemirror-adapter/solid@256

@prosemirror-adapter/svelte

npm i https://pkg.pr.new/@prosemirror-adapter/svelte@256

@prosemirror-adapter/vue

npm i https://pkg.pr.new/@prosemirror-adapter/vue@256

commit: aea274e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant