feat(react): let WikilinkHoverCard children return a Promise<ReactNode>#296
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
ocavue
force-pushed
the
async-hover-card-body
branch
from
c2e5770 to
bf79401
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WikilinkHoverCardchildren may now return a promise: the card stays closed until it resolves, resolving tonullor rejecting renders no card, and a result that lands after the pointer moved on is discarded. This lets hosts with asynchronous local content (like Reflect) resolve the target before anything shows, instead of opening an empty card while loading or for a missing note.