Skip to content

fix(core): keep the virtual caret one line tall beside a wrapped wikilink#293

Merged
ocavue merged 1 commit into
masterfrom
wikilink-caret-height
Jul 12, 2026
Merged

fix(core): keep the virtual caret one line tall beside a wrapped wikilink#293
ocavue merged 1 commit into
masterfrom
wikilink-caret-height

Conversation

@ocavue

@ocavue ocavue commented Jul 12, 2026

Copy link
Copy Markdown
Member

The caret beside an atom mark boundary measured the preview's bounding box, so a wikilink wrapped across lines drew a caret spanning every line, and the end-of-paragraph caret landed at the wrong x/y. Measure the preview's line fragment beside the caret instead.

Before

image image

After

image image

@vercel

vercel Bot commented Jul 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
meowdown Building Building Preview Jul 12, 2026 10:42am

@pkg-pr-new

pkg-pr-new Bot commented Jul 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/prosekit/meowdown/@meowdown/core@293
npm i https://pkg.pr.new/prosekit/meowdown/@meowdown/react@293

commit: c08c27b

@github-actions

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 93.95% 3624 / 3857
🔵 Statements 91.64% 4039 / 4407
🔵 Functions 91.84% 878 / 956
🔵 Branches 85.89% 2479 / 2886
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/core/src/extensions/caret-rect.ts 98.03% 94.59% 100% 100% 72
Generated in workflow #1191 for commit c08c27b by the Vitest Coverage Report Action

@ocavue ocavue marked this pull request as ready for review July 12, 2026 11:02
@ocavue ocavue merged commit 08362a1 into master Jul 12, 2026
10 checks passed
@ocavue ocavue deleted the wikilink-caret-height branch July 12, 2026 11:02
@ocavuebot ocavuebot mentioned this pull request Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant