feat: add wiki-link hover cards#288
Closed
maccman wants to merge 1 commit into
Closed
Conversation
|
@maccman is attempting to deploy a commit to the ocavue's projects Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
Member
|
I will simplify it in another PR |
Member
|
implemented in #291 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Hosts need a supported way to attach local preview content to rendered wiki links without reaching into Meowdown DOM internals. The hover lifecycle also has to survive editor transactions so deleting or rewriting the hovered mark always closes the overlay.
What changed
WikilinkHoverCardwith a 300 ms dwell, immediate leave, collision avoidance, focus neutrality, and request-scoped dismissalinteractiveandrenderEmbedscontrols toMarkdownViewfor inert local preview renderingTesting
pnpm typecheckpnpm lintpnpm buildCI=1 MEOWDOWN_TEST_BROWSER=chromium pnpm exec vitest run— 90 files, 1,681 passing tests and 13 expected failures