Skip to content

feat: add wiki-link hover cards#288

Closed
maccman wants to merge 1 commit into
prosekit:masterfrom
maccman:codex/wikilink-hover-card
Closed

feat: add wiki-link hover cards#288
maccman wants to merge 1 commit into
prosekit:masterfrom
maccman:codex/wikilink-hover-card

Conversation

@maccman

@maccman maccman commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Why

Hosts need a supported way to attach local preview content to rendered wiki links without reaching into Meowdown DOM internals. The hover lifecycle also has to survive editor transactions so deleting or rewriting the hovered mark always closes the overlay.

What changed

  • add a delegated, transaction-aware wiki-link hover handler with direct visible-element anchors
  • add a passive WikilinkHoverCard with a 300 ms dwell, immediate leave, collision avoidance, focus neutrality, and request-scoped dismissal
  • add interactive and renderEmbeds controls to MarkdownView for inert local preview rendering
  • resolve wiki-link clicks and hovers from the hidden source holder, fixing adjacent wide-alias hit testing
  • document the public core and React APIs and cover link deletion, replacement, teardown, rerenders, collisions, and passive rendering

Testing

  • pnpm typecheck
  • pnpm lint
  • pnpm build
  • CI=1 MEOWDOWN_TEST_BROWSER=chromium pnpm exec vitest run — 90 files, 1,681 passing tests and 13 expected failures
  • targeted WebKit feature suite — 43 tests passed

@vercel

vercel Bot commented Jul 11, 2026

Copy link
Copy Markdown

@maccman is attempting to deploy a commit to the ocavue's projects Team on Vercel.

A member of the Team first needs to authorize it.

@pkg-pr-new

pkg-pr-new Bot commented Jul 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/prosekit/meowdown/@meowdown/core@288
npm i https://pkg.pr.new/prosekit/meowdown/@meowdown/react@288

commit: 834b053

@ocavue

ocavue commented Jul 12, 2026

Copy link
Copy Markdown
Member

I will simplify it in another PR

@ocavue

ocavue commented Jul 12, 2026

Copy link
Copy Markdown
Member

implemented in #291

@ocavue ocavue closed this Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants