feat(react): add attach file slash command#261
Merged
Conversation
|
@maccman is attempting to deploy a commit to the ocavue's projects Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hosts can persist pasted or dropped files through
onFilePaste, but users who prefer command menus had no built-in slash command for choosing a file from disk. The slash menu also needed to keep using the same markdown shape as paste/drop so attachments render consistently as images or file pills.Before -> After
/showed the built-in formatting/table/time commands plus host items.onFilePasteis configured,/attachshowsAttach fileand opens a hidden file picker.onFilePaste,onFileSaveError, andbuildFileMarkdown.Changes
Attach fileslash menu item inSlashMenuwhenonFilePasteis present.buildFileMarkdown, and inserts the markdown at the current editor selection.onFilePasteandonFileSaveErrorfromProseKitEditorintoSlashMenu.slash-menu.test.tsx, including query removal before insertion.Verification
git diff --checkpassed.pnpm vitest run packages/react/src/components/slash-menu.test.tsxpassed.pnpm exec oxfmt --check packages/react/src/components/slash-menu.tsx packages/react/src/components/prosekit-editor.tsx packages/react/src/components/slash-menu.test.tsxpassed.pnpm exec eslint --max-warnings 0 packages/react/src/components/slash-menu.tsx packages/react/src/components/prosekit-editor.tsx packages/react/src/components/slash-menu.test.tsxpassed.pnpm typecheckpassed.Risk / Rollout
No migrations or rollout steps. The command is only shown when a host has already opted into file persistence via
onFilePaste; hosts without that handler keep the existing menu behavior.