This repository was archived by the owner on Jun 2, 2026. It is now read-only.
fix: clone protocol tests not running in CI#423
Open
tamaralipows wants to merge 3 commits into
Open
Conversation
Clone protocols reuse a base protocol's substreams directory rather than having their own. Because the CI only discovered protocols by scanning top-level directories, clone protocols were invisible to the test matrix and never ran. - Extend CI matrix detection to include clone protocols and trigger them when their base directory changes - Resolve clone names to their base directory in the Docker build/filter - Add missing clone-to-base mappings (base-alienbase-v3, unichain-curve) - Infer chain and RPC URL from protocol name prefix in the entrypoint - Rename unichain-curve integration test file to match naming convention Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The tycho-indexer reads RPC_URL from the environment, but in Docker RPC_URL is always the Ethereum endpoint. Non-Ethereum protocols (Base, Arbitrum, etc.) were hitting the wrong RPC and getting 401 errors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dianacarvalho1
approved these changes
Apr 17, 2026
dianacarvalho1
left a comment
dianacarvalho1
left a comment
Contributor
There was a problem hiding this comment.
perfection! Thank you 🙏🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of what was wrong:
Clone protocols reuse a base protocol's substreams directory rather than having their own. Because the CI only discovered protocols by scanning top-level directories, clone protocols were invisible to the test matrix and never ran.
Clone protocol detection fixes:
Clones successfully detected here: https://github.com/propeller-heads/tycho-protocol-sdk/actions/runs/24539388245
Base fixes:
Proof this works - base aerodrome v1 was not passing before. Note it failed in the base integration PR: #413
But it runs here: https://github.com/propeller-heads/tycho-protocol-sdk/actions/runs/24535243101/job/71730807057
TODO:
Note: