Conversation
Member
Author
|
@arnedesmedt tests on PHP 8.4 are failing. You might want to address that before we build release. Want to submit a PR? |
Member
|
note that the error occures on php8.4 with the --prefer-lowest flag. That mean it installs a really old version of phpunit v9 that does support php8.4 php8.4 is currently not supported by phpunit I guess it is might be 'bout time we drop support for some older php versions (< PHP 8.2)? That way we can bump and fix phpunit test to be compatibvle with phpunit@v11 Other options? |
Member
Author
|
Sounds good to me
…On Mon, Feb 10, 2025, 10:26 Bas Kamer ***@***.***> wrote:
note that the error occures on php8.4 with the --prefer-lowest flag. That
mean it installs a really old version of phpunit v9 that does support php8.4
php8.4 is currently not supported
<https://phpunit.de/supported-versions.html> by phpunit
I guess it is might be 'bout time we drop support for some older php
versions (< PHP 8.2)? That way we can bump and fix phpunit test to be
compatibvle with ***@***.***
Other options?
—
Reply to this email directly, view it on GitHub
<#85 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADAJPGTREA7DRKPPG3O3B32PCSJNAVCNFSM6AAAAABWSLISQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBXHE4DMMBZGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
ping @codeliner opinions or options? |
* wrong (empty) directive * static data provider * fix test warn * bumped php & phpunit * migrated phpunit conf * ignore phpunit cache dir * migrate to attributes * refactor around deprecated getMockForAbstractClass * cs
Member
|
are we ready to release this one? |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
required for upcoming release
see #84