fix(skills): scan staged payload with SkillSpector#264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
skillspector-report.mdartifact link.Security / release benefit
Testing
for test_file in scripts/test-skill-*.mjs; do node "$test_file"; donenpx eslint scripts/ci/simulate_skill_tag_release.mjs scripts/test-skill-release-workflow.mjs scripts/test-skill-tag-release-simulation.mjs --max-warnings 0npx tsc --noEmitgit diff --checknpm run buildGenerated description
Below is a concise technical summary of the changes proposed in this PR:
Align release workflows to scan the staged release payload by running
generate_skillspector_reportagainst the archived output and propagating that behavior throughscripts/ci/simulate_skill_tag_release.mjsand its test shim. Embed the generatedskillspector-report.mdinto the GitHub release body via a new preparation step that also provides a release notes link, with tests validating the resulting workflow structure.generate_skillspector_reportinvocations and the fake SkillSpector helper so the dry-run, tag-release build, and simulation scripts scan the staged payload (inner_dir) rather than the source directory, preventing source-only test fixtures from leaking into the report.Modified files (3)
Latest Contributors(2)
Modified files (2)
Latest Contributors(2)